Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Set neural-search plugin 3.0.0 baseline JDK version to JDK-21 #775

Closed
Tracked by #14011
reta opened this issue Jun 5, 2024 · 4 comments · Fixed by #838
Closed
Tracked by #14011

[FEATURE] Set neural-search plugin 3.0.0 baseline JDK version to JDK-21 #775

reta opened this issue Jun 5, 2024 · 4 comments · Fixed by #838

Comments

@reta
Copy link
Contributor

reta commented Jun 5, 2024

Is your feature request related to a problem? Please describe

Set neural-search plugin 3.0.0 baseline JDK version to JDK-21

Describe the solution you'd like

See please opensearch-project/OpenSearch#10745

Related component

Build

Describe alternatives you've considered

N/A

Additional context

See please opensearch-project/OpenSearch#14011

@dblock
Copy link
Member

dblock commented Jul 1, 2024

[Catch All Triage - Attendees 1, 2, 3, 4, 5]

@martin-gaievski
Copy link
Member

following PRs related to adding JDK21, they were done before/separately from this campaign:

#565
#801
#837
#801

@martin-gaievski
Copy link
Member

@reta is there anything left for neural search plugin in scope of this campaign? We have done multiple small PRs that added jdk21 to different plugin areas, list is here #775 (comment).

@reta
Copy link
Contributor Author

reta commented Jul 19, 2024

@reta is there anything left for neural search plugin in scope of this campaign? We have done multiple small PRs that added jdk21 to different plugin areas, list is here #775 (comment).

Yes, we need to update baseline here https://github.com/opensearch-project/neural-search/blob/main/build.gradle#L158

allprojects {
    ...
    targetCompatibility = JavaVersion.VERSION_21
    sourceCompatibility = JavaVersion.VERSION_21
    ...
}

Thanks @martin-gaievski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants