Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set neural-search plugin 3.0.0 baseline JDK version to JDK-21 #838

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Jul 19, 2024

Description

Set neural-search plugin 3.0.0 baseline JDK version to JDK-21

Issues Resolved

Closes #775

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Contributor Author

reta commented Jul 19, 2024

@martin-gaievski fyi :-)

@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jul 19, 2024
@martin-gaievski martin-gaievski merged commit 6811660 into opensearch-project:main Jul 19, 2024
38 of 39 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-838-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 68116603566107785c0439fa0599a044e4fddf8a
# Push it to GitHub
git push --set-upstream origin backport/backport-838-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-838-to-2.x.

@reta
Copy link
Contributor Author

reta commented Jul 19, 2024

Thanks @martin-gaievski , please note - this is 3.x / main only, no backport is needed

@martin-gaievski
Copy link
Member

understood, removing 'backport 2.x' label. Is the a plan to move 2.x to 21 at some point?

@martin-gaievski martin-gaievski removed the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jul 19, 2024
@reta
Copy link
Contributor Author

reta commented Jul 19, 2024

Is the a plan to move 2.x to 21 at some point?

Not a baseline (== minimum required JDK version), as it would be breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set neural-search plugin 3.0.0 baseline JDK version to JDK-21
3 participants