-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set neural-search plugin 3.0.0 baseline JDK version to JDK-21 #838
Conversation
Signed-off-by: Andriy Redko <[email protected]>
@martin-gaievski fyi :-) |
6811660
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-838-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 68116603566107785c0439fa0599a044e4fddf8a
# Push it to GitHub
git push --set-upstream origin backport/backport-838-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Thanks @martin-gaievski , please note - this is 3.x / main only, no backport is needed |
understood, removing 'backport 2.x' label. Is the a plan to move 2.x to 21 at some point? |
Not a baseline (== minimum required JDK version), as it would be breaking change |
Description
Set neural-search plugin 3.0.0 baseline JDK version to JDK-21
Issues Resolved
Closes #775
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.