-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding weights param for combination technique #235
Merged
martin-gaievski
merged 5 commits into
opensearch-project:feature/normalization
from
martin-gaievski:add_algo_params_for_combination
Jul 28, 2023
Merged
Adding weights param for combination technique #235
martin-gaievski
merged 5 commits into
opensearch-project:feature/normalization
from
martin-gaievski:add_algo_params_for_combination
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/normalization #235 +/- ##
===========================================================
+ Coverage 85.55% 85.95% +0.40%
- Complexity 296 310 +14
===========================================================
Files 24 24
Lines 872 904 +32
Branches 134 137 +3
===========================================================
+ Hits 746 777 +31
Misses 67 67
- Partials 59 60 +1
|
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
July 27, 2023 00:45
heemin32
reviewed
Jul 27, 2023
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Outdated
Show resolved
Hide resolved
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Show resolved
Hide resolved
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Outdated
Show resolved
Hide resolved
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Outdated
Show resolved
Hide resolved
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/combination/ScoreCombinationFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/combination/ScoreCombinationFactory.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/factory/NormalizationProcessorFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/factory/NormalizationProcessorFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/factory/NormalizationProcessorFactory.java
Outdated
Show resolved
Hide resolved
HenryL27
reviewed
Jul 27, 2023
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_algo_params_for_combination
branch
from
July 27, 2023 17:18
751db4d
to
e320ed3
Compare
heemin32
reviewed
Jul 27, 2023
...g/opensearch/neuralsearch/processor/combination/ArithmeticMeanScoreCombinationTechnique.java
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add_algo_params_for_combination
branch
from
July 27, 2023 18:09
5a8c6b3
to
376af08
Compare
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
heemin32
approved these changes
Jul 27, 2023
junqiu-lei
approved these changes
Jul 28, 2023
martin-gaievski
merged commit Jul 28, 2023
fe72dbc
into
opensearch-project:feature/normalization
14 checks passed
martin-gaievski
added a commit
that referenced
this pull request
Aug 3, 2023
* Adding weights param for combination technique Signed-off-by: Martin Gaievski <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding parameter "weights" for combination technique in normalization processor. Weights are use to multiply scores for each sub-query from the Hybrid search query. Weights are mapped to sub-query based on position (index), if there are less weights provided we use "1.0" for the rest of sub-query scores. If there are more weights provided we take first N and ignore the rest.
Parameter is set as part of the search pipeline, example of such request:
Issues Resolved
#228, part of solution for #126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
skip