[Backport 2.x] Adding aggregations in hybrid query (#630) #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding aggregations in hybrid query Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit f04c058)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #631 +/- ##
============================================
- Coverage 83.37% 83.24% -0.13%
- Complexity 658 664 +6
============================================
Files 51 52 +1
Lines 2069 2071 +2
Branches 333 332 -1
============================================
- Hits 1725 1724 -1
Misses 196 196
- Partials 148 151 +3 ☔ View full report in Codecov by Sentry. |
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
jmazanec15
approved these changes
Mar 12, 2024
navneet1v
approved these changes
Mar 12, 2024
martin-gaievski
merged commit 4043f9f
into
opensearch-project:2.x
87 of 89 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of f04c058 from #630
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.