Jenkinsfile update for Gradle Check Publish Optimization #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
prudhvigodithi
changed the title
prudhvigodithi
commented
May 22, 2024
| @@ -111,7 +113,7 @@ pipeline { | |||
| if (!env.BUILD_CAUSE.contains('Started by user') && !env.BUILD_CAUSE.contains('Started by timer')) { | |||
| def pr_url = "${pr_to_clone_url}".replace(".git", "/pull/${pr_number}") | |||
| println("Triggered by GitHub: ${pr_to_clone_url}") | |||
| if ("$pr_number" == "Null") { | |||
| if ("$post_merge_action" == "true") { | |||
There was a problem hiding this comment.
With this change https://github.com/opensearch-project/OpenSearch/pull/13786/files the pr_number is not null anymore. A new field post_merge_action with true/false is added to identify the push event.
| break | ||
| case "${pr_number}" == "Null": | ||
| case "${post_merge_action}" == "true": |
There was a problem hiding this comment.
Same as above.
With this change https://github.com/opensearch-project/OpenSearch/pull/13786/files the pr_number is not null anymore. A new field post_merge_action with true/false is added to identify the push event.
gaiksaya
approved these changes
May 22, 2024
Signed-off-by: Prudhvi Godithi <[email protected]>
prudhvigodithi
force-pushed
the
gradle-check
branch
from
a0c8e73
to
c57c5e3
Compare
|
|
prudhvigodithi
requested review from
dblock,
peterzhuamazon,
bbarani,
rishabh6788,
zelinh,
Divyaasm and
tianleh
as code owners
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from opensearch-project/OpenSearch#11217 (comment), this PR will ensure we have the PR number identified by commitID even for post_merge_action. This data will be used in gradle metrics dashboard OpenSearch Gradle Check Metrics.
With this change we can get the associated PR for failed tests on
post_merge_action.The required library change PR opensearch-project/opensearch-build-libraries#427.
The required gradle check change PR opensearch-project/OpenSearch#13786.
Issues Resolved
Part of: opensearch-project/OpenSearch#3713
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.