-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTO] Update input manifests #5135
Conversation
- name: opensearch-system-templates | ||
integ-test: | ||
test-configs: | ||
- with-security | ||
- without-security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @peterzhuamazon,
Do you know from where the data is generated. Looks like some flags are missing https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.17.0/opensearch-2.17.0-test.yml#L167-L169
cc: @vikasvb90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the place to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-10-25 00:51:25 INFO Using /var/jenkins/workspace/manifest-update/manifests/2.18.0/opensearch-2.18.0.yml as the base input manifest
2024-10-25 00:51:25 INFO Using /var/jenkins/workspace/manifest-update/manifests/2.18.0/opensearch-2.18.0-test.yml as the base test manifest
2024-10-25 00:51:25 INFO Wrote /var/jenkins/workspace/manifest-update/manifests/2.19.0/opensearch-2.19.0.yml as the new input manifest
2024-10-25 00:51:25 INFO Wrote /var/jenkins/workspace/manifest-update/manifests/2.19.0/opensearch-2.19.0-test.yml as the new test manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yes it is based on the 2.18.0-test manifest.
I will update both 2.18 and 2.19.
a23804a
to
32fb507
Compare
- '2.15' | ||
- '2.16' | ||
- '2.17' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want to keep these for patch increments like opensearch-project/k-NN#1944 (See the conversation there)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a rare care we will have a release for these tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right but it is a good practice to keep the branches up to date for emergency release like log4j
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I didnt realize 2.17 is the last version.
I thought we are already on 2.19 now 😄
let me change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would still recommend to keep all versions @prudhvigodithi can add too. Its just keeping the automation running from our end. At the end its on maintainers to accept it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep the changes to what the PR description and title says or update it. 2.17.2 manifests I believe should be in manifest for now until 2.18.0 is out.
Moved 2.17 back, thought we are already on 2.19 for some reason 😄 . Thanks. |
70d9c68
to
f7e0b48
Compare
Signed-off-by: opensearch-ci <[email protected]>
f7e0b48
to
0bbbf71
Compare
Hi @peterzhuamazon Looks like your changes were reset. Can you create another PR with those? Merging this to unblock 2.19 artifacts. |
I have noticed that a repo has incremented a version. This change updates the corresponding input manifests.