Add functional test for dashboard assistant trace page #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
changed the title
Signed-off-by: Hailong Cui <[email protected]>
ruanyl
approved these changes
Jan 29, 2024
wanglam
reviewed
Jan 30, 2024
| @@ -27,7 +29,11 @@ const server = http.createServer((req, res) => { | |||
| // Why add a delay here? reference: https://github.com/opensearch-project/ml-commons/issues/1894 | |||
| setTimeout(() => { | |||
| if (requestBody.includes(MATCH_AGENT_FRAMEWORK_PROMPT)) { | |||
| return res.end(JSON.stringify(agentFrameworkJson)); | |||
| if (requestBody.includes(TOOL_RESPONSE)) { | |||
There was a problem hiding this comment.
Is this TOOL RESPONSE request from the ml-commons side? Since we are adding a specific response for agentFrameworkThoughtJson, could we just add a condition just like below. Preferring add else if(requestBody.includes(MATCH_THOUGHT_PROMPT))) {.
There was a problem hiding this comment.
Yes, TOOL RESPONSE comes from ml-common side and it's part of prompt when we have tool involved.
The first LLM call prompt is MATCH_AGENT_FRAMEWORK_PROMPT...., when some tool been involved, prompt becomes MATCH_AGENT_FRAMEWORK_PROMPT.... TOOL_RESPONSE:...., i am not quite follow your comments here.
There was a problem hiding this comment.
Got your point, Let's keep current implementation
cypress/integration/plugins/dashboards-assistant/chatbot_interaction_trace_spec.js
Show resolved
Hide resolved
cypress/integration/plugins/dashboards-assistant/chatbot_interaction_trace_spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
wanglam
approved these changes
Jan 30, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1012-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32cba8323cc07910b2e9c7babc8dc3b424adc684
# Push it to GitHub
git push --set-upstream origin backport/backport-1012-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1012-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32cba8323cc07910b2e9c7babc8dc3b424adc684
# Push it to GitHub
git push --set-upstream origin backport/backport-1012-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Hailong-am
added a commit
to Hailong-am/opensearch-dashboards-functional-test
that referenced
this pull request
Jan 30, 2024
…oject#1012) * Add functional test for trace page Signed-off-by: Hailong Cui <[email protected]> * update to ask question direclty instead of click Signed-off-by: Hailong Cui <[email protected]> * replace focus with click Signed-off-by: Hailong Cui <[email protected]> * add wait before input Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 32cba83)
Hailong-am
added a commit
that referenced
this pull request
Jan 30, 2024
* Add functional test for trace page Signed-off-by: Hailong Cui <[email protected]> * update to ask question direclty instead of click Signed-off-by: Hailong Cui <[email protected]> * replace focus with click Signed-off-by: Hailong Cui <[email protected]> * add wait before input Signed-off-by: Hailong Cui <[email protected]> * address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 32cba83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chatbot_interaction_trace_spec.js.mp4
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.