-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add functional test for datasources at observability dashboards plugin #1024
[Backport 2.x] Add functional test for datasources at observability dashboards plugin #1024
Conversation
opensearch-project#987) * Add functional test for datasources at observability dashboards plugin Signed-off-by: Ryan Liang <[email protected]> * Extend the header locating to 2 mins Signed-off-by: Ryan Liang <[email protected]> * Fix lint Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997 I fixed an testing running forever issue recently for observability, and I noticed two tests are failing for Could you take a look? 7_datasources_dashboard.spec.js.mp4 |
@ruanyl can you check https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7720266678/job/21044878653?pr=1024, it still run forever? |
The PR hasn't merged #1023 |
@ruanyl I can take a look on this. This is due to the enable of security, so that the url has the slug of security tenant. |
Signed-off-by: Ryan Liang <[email protected]>
Hi @ruanyl, thx for the reminder. I have fixed the issue. Could you please verify that? |
Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997 thanks for the fix! Btw, maybe you want to create another PR to apply the same fix to |
Description
Add functional test for datasources at observability dashboards plugin
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.