changed flakey tests for query-workbench #1025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
@sumukhswamy The lint check failed, could you take a look? The query workbench release tests are failed as well. |
there is PR pending to be merged in workbench which has a few changes thats why the tests are failing |
Signed-off-by: sumukhswamy <[email protected]>
|
@sumukhswamy Is the fix merged in main? |
yes it has |
|
@sumukhswamy could you please post the result in your local env as the latest 3.0.0 build has some error when launching. |
SuZhou-Joe
approved these changes
Feb 8, 2024
SuZhou-Joe
reviewed
Feb 8, 2024
| cy.wait(QUERY_WORKBENCH_DELAY); | ||
| cy.get('.euiButton__text[title=PPL]').click({ force: true }); | ||
| cy.wait(QUERY_WORKBENCH_DELAY); | ||
| cy.wait(1000); |
There was a problem hiding this comment.
Any reason why we replace the const QUERY_WORKBENCH_DELAY with 1000?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added changes for workbench changes
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.