Fix flaky test for vis-augmenter #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
ruanyl
approved these changes
Feb 2, 2024
Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
approved these changes
Feb 2, 2024
|
pls hold on merge, there is no test run for this change. |
Signed-off-by: Hailong Cui <[email protected]>
|
Saw there are failed test cases related to visualization, is it supposed to be fixed by this change or it's not related? |
It's not related, this PR focus on vis-augmenter related test cases. |
Signed-off-by: Hailong Cui <[email protected]>
|
@Hailong-am what's the status of this PR? can we merge? |
Still have issue for the vis-augmenter, under investigation |
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
…is-augmenter-flaky-test
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
vis-augmenter-flaky-test
branch
from
43f6bcf
to
dd3f561
Compare
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
|
test result https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7999641394 without security with security |
kavilla
approved these changes
Feb 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
* wait for dashboard to be searchable Signed-off-by: Hailong Cui <[email protected]> * refresh private tenant kibana index also Signed-off-by: Hailong Cui <[email protected]> * Add one more filter for core ft Signed-off-by: Hailong Cui <[email protected]> * Add CYPRESS_NO_COMMAND_LOG flag Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * wait for page load Signed-off-by: Hailong Cui <[email protected]> * firefox Signed-off-by: Hailong Cui <[email protected]> * revert test code Signed-off-by: Hailong Cui <[email protected]> * wait for page load Signed-off-by: Hailong Cui <[email protected]> * add more timeout Signed-off-by: Hailong Cui <[email protected]> * add more checks Signed-off-by: Hailong Cui <[email protected]> * add vis to dashboard Signed-off-by: Hailong Cui <[email protected]> * no command log Signed-off-by: Hailong Cui <[email protected]> * use correct flag CYPRESS_NO_COMMAND_LOG Signed-off-by: Hailong Cui <[email protected]> * set to global tenant when security enabled Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit e9fa679)
Hailong-am
added a commit
that referenced
this pull request
Feb 23, 2024
* wait for dashboard to be searchable Signed-off-by: Hailong Cui <[email protected]> * refresh private tenant kibana index also Signed-off-by: Hailong Cui <[email protected]> * Add one more filter for core ft Signed-off-by: Hailong Cui <[email protected]> * Add CYPRESS_NO_COMMAND_LOG flag Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * only run vis-augmenter for debug Signed-off-by: Hailong Cui <[email protected]> * wait for page load Signed-off-by: Hailong Cui <[email protected]> * firefox Signed-off-by: Hailong Cui <[email protected]> * revert test code Signed-off-by: Hailong Cui <[email protected]> * wait for page load Signed-off-by: Hailong Cui <[email protected]> * add more timeout Signed-off-by: Hailong Cui <[email protected]> * add more checks Signed-off-by: Hailong Cui <[email protected]> * add vis to dashboard Signed-off-by: Hailong Cui <[email protected]> * no command log Signed-off-by: Hailong Cui <[email protected]> * use correct flag CYPRESS_NO_COMMAND_LOG Signed-off-by: Hailong Cui <[email protected]> * set to global tenant when security enabled Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit e9fa679) Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some wait time to dashboard to be searchable
Issues Resolved
#1118
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.