-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cypress tests to run datagrid table in Discover #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Zhuang <[email protected]>
Signed-off-by: Anan <[email protected]>
Signed-off-by: Anan <[email protected]>
ananzh
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
February 6, 2024 23:51
ashwin-pc
approved these changes
Feb 6, 2024
ruanyl
approved these changes
Feb 7, 2024
Signed-off-by: Anan <[email protected]>
@ananzh Do we need to get this PR merged for 2.12? |
@SuZhou-Joe yes we do. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* allow switch table * make sure the DatePickerMenu is open * update switchDiscoverTable to accomadate changing from toggle to button * skip saved queries * fixed flaky tests and missing ones --------- Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 34a2630)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* allow switch table * make sure the DatePickerMenu is open * update switchDiscoverTable to accomadate changing from toggle to button * skip saved queries * fixed flaky tests and missing ones --------- Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 34a2630)
kavilla
pushed a commit
that referenced
this pull request
Feb 7, 2024
* allow switch table * make sure the DatePickerMenu is open * update switchDiscoverTable to accomadate changing from toggle to button * skip saved queries * fixed flaky tests and missing ones --------- Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 34a2630) Co-authored-by: Anan Zhuang <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Feb 7, 2024
* allow switch table * make sure the DatePickerMenu is open * update switchDiscoverTable to accomadate changing from toggle to button * skip saved queries * fixed flaky tests and missing ones --------- Signed-off-by: Anan Zhuang <[email protected]> (cherry picked from commit 34a2630) Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables cypress tests to run datagrid table. By navigating via
cy.switchDiscoverTable('new');
, discover will load datagrid table. This will accomadate the changes due to the change of restore legacy table in this PR opensearch-project/OpenSearch-Dashboards#5789We will temporarily skip
apps/data_explorer/saved_queries.spec.js
due to a bug. Once we fixed the issue, we will restore the test.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.