Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cypress tests to run datagrid table in Discover #1074

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 6, 2024

Description

This PR enables cypress tests to run datagrid table. By navigating via cy.switchDiscoverTable('new');, discover will load datagrid table. This will accomadate the changes due to the change of restore legacy table in this PR opensearch-project/OpenSearch-Dashboards#5789

We will temporarily skip apps/data_explorer/saved_queries.spec.js due to a bug. Once we fixed the issue, we will restore the test.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe
Copy link
Member

@ananzh Do we need to get this PR merged for 2.12?

@ananzh
Copy link
Member Author

ananzh commented Feb 7, 2024

@SuZhou-Joe yes we do.

@ananzh ananzh merged commit 34a2630 into main Feb 7, 2024
40 of 47 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
* allow switch table
* make sure the DatePickerMenu is open
* update switchDiscoverTable to accomadate changing from toggle to button
* skip saved queries
* fixed flaky tests and missing ones

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 34a2630)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 7, 2024
* allow switch table
* make sure the DatePickerMenu is open
* update switchDiscoverTable to accomadate changing from toggle to button
* skip saved queries
* fixed flaky tests and missing ones

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 34a2630)
kavilla pushed a commit that referenced this pull request Feb 7, 2024
* allow switch table
* make sure the DatePickerMenu is open
* update switchDiscoverTable to accomadate changing from toggle to button
* skip saved queries
* fixed flaky tests and missing ones

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 34a2630)

Co-authored-by: Anan Zhuang <[email protected]>
kavilla pushed a commit that referenced this pull request Feb 7, 2024
* allow switch table
* make sure the DatePickerMenu is open
* update switchDiscoverTable to accomadate changing from toggle to button
* skip saved queries
* fixed flaky tests and missing ones

---------

Signed-off-by: Anan Zhuang <[email protected]>
(cherry picked from commit 34a2630)

Co-authored-by: Anan Zhuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants