[OSD] Skip cypress tests for data explorer with security enabled #1120
Conversation
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
| cy.visit(clipboardData); | ||
| cy.waitForLoader(); | ||
| // TODO: tries to re-route with a different origin | ||
| // cy.visit(clipboardData); |
There was a problem hiding this comment.
@leanneeliatra would you think this is ok?
There was a problem hiding this comment.
Yes this looks good to me @kavilla
Have the tests been ran too, to make sure they still run okay and all is expected with this change?
|
As 2.12 has been released, I will remove the |
In case there is a patch. Do we want to backport to 2.12 since those tests are inaccurate when installing the security plugin. |
| cy.getElementByTestId('exportAsSavedObject') | ||
| .get('.euiRadio__input') | ||
| .should('be.disabled'); | ||
| if (!Cypress.env('SECURITY_ENABLED')) { |
There was a problem hiding this comment.
I am not a fan of this.
We could just strip the tenant from the query string and then compare. In fact, checking if the URL is identical is not a good idea; we should check if the elements we want are there, in whatever order.
|
Closing. Will track with this: opensearch-project/OpenSearch-Dashboards#6220 (comment) |
Description
When security is enabled the url contains the tenancy. For example,
Which will fail tests that verify URLs if written without security plugin and tenancy enabled. Also with the security plugin enabled then the query string is masked. Which will make it more difficult to verify URL tests without checking the expecting elements within the app. So to mitigate this we will just check the URLs only if security is not enabled but keep the tests running if enabled.
Also includes browserPermissions as one of the tests would pop up and asks but needs permission. Also commented on the cy.visit. Depending on how the tests are executed this could be a re-navigate on origin. But since it just focuses on visiting but fails the tests when it does visit but not validate anything on the location then commented out.
Issues Resolved
opensearch-project/OpenSearch-Dashboards#5633
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.