[Multiple Datasource]Fix failed test cases caused by switching from EuiSelect to EuiSuperSelect #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
changed the title
…erSelect Signed-off-by: Su <[email protected]>
zhongnansu
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
zhongnansu
changed the title
xinruiba
approved these changes
Apr 2, 2024
|
Checked failed CI, not relate to code change in this PR. All MD related tests passed |
Hailong-am
approved these changes
Apr 3, 2024
SuZhou-Joe
approved these changes
Apr 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
…erSelect (#1199) Signed-off-by: Su <[email protected]> (cherry picked from commit e4f0ccd)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 3, 2024
…erSelect (#1199) (#1203) Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit e4f0ccd) Co-authored-by: Zhongnan Su <[email protected]>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…erSelect (opensearch-project#1199) Signed-off-by: Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Replace OuiSelect component with OuiSuperSelect in data-source plugin OpenSearch-Dashboards#5315, we switched from
EuiSelecttoEuiSuperSelect, causing some test cases to fail. This PR addressed these failures, and make sure all related tests can passclean the code by using existing util functions, and constants
Issues Resolved
#1198
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.