Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace analytics cypress update for 2.15 #1376

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jun 11, 2024

Description

  • Moves trace groups to trace page
  • Add service flyout test

Issues Resolved

#1269

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48
Copy link
Member Author

ps48 commented Jun 11, 2024

Looks like OpenSearch is not loading up due to jar hell from flow-framework:

Error: 6-11T15:51:40,337][ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [fv-az883-120] uncaught exception in thread [main]
uncaught exception in thread [main]
org.opensearch.bootstrap.StartupException: java.lang.IllegalStateException: failed to load plugin opensearch-flow-framework due to jar hell
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:185) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:172) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) ~[opensearch-cli-3.0.0.jar:3.0.0]
	at org.opensearch.cli.Command.main(Command.java:101) ~[opensearch-cli-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:138) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:104) ~[opensearch-3.0.0.jar:3.0.0]
Caused by: java.lang.IllegalStateException: failed to load plugin opensearch-flow-framework due to jar hell
	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:693) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.plugins.PluginsService.loadBundles(PluginsService.java:543) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.plugins.PluginsService.<init>(PluginsService.java:197) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.node.Node.<init>(Node.java:499) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.node.Node.<init>(Node.java:426) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:181) ~[opensearch-3.0.0.jar:3.0.0]
	... 6 more
Caused by: java.lang.IllegalStateException: /home/runner/work/opensearch-dashboards-functional-test/opensearch-dashboards-functional-test/opensearch-3.0.0/plugins/opensearch-flow-framework/opensearch-flow-framework-3.0.0.0.jar requires Java 21:, your system: 14.0.2+12
	at org.opensearch.bootstrap.JarHell.checkJavaVersion(JarHell.java:278) ~[opensearch-common-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.JarHell.checkManifest(JarHell.java:251) ~[opensearch-common-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.JarHell.checkJarHell(JarHell.java:206) ~[opensearch-common-3.0.0.jar:3.0.0]
	at org.opensearch.plugins.PluginsService.checkBundleJarHell(PluginsService.java:679) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.plugins.PluginsService.loadBundles(PluginsService.java:543) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.plugins.PluginsService.<init>(PluginsService.java:197) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.node.Node.<init>(Node.java:499) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.node.Node.<init>(Node.java:426) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404) ~[opensearch-3.0.0.jar:3.0.0]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:181) ~[opensearch-3.0.0.jar:3.0.0]
	... 6 more

@ps48
Copy link
Member Author

ps48 commented Jun 11, 2024

Local cypress tests runs with security:

1_trace_analytics_dashboard.spec.js.mp4
2_trace_analytics_services.spec.js.mp4
3_trace_analytics_traces.spec.js.mp4

@ps48
Copy link
Member Author

ps48 commented Jun 11, 2024

@tianleh @CCongWang Can you please help review this PR and backport it to 2.x?

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CCongWang CCongWang merged commit 05784d3 into opensearch-project:main Jun 11, 2024
39 of 40 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 05784d3)
CCongWang pushed a commit that referenced this pull request Jun 11, 2024
Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 05784d3)

Co-authored-by: Shenoy Pratik <[email protected]>
@dbwiddis
Copy link
Member

Looks like OpenSearch is not loading up due to jar hell from flow-framework:

Flow Framework 3.0.0 branch now uses JDK21 source/target compatibility per opensearch-project/OpenSearch#14011

This was not backported to 2.x, so should not impact 2.15 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants