-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix channel tests #1507
Fix channel tests #1507
Conversation
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1507-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09bf9ce4d661b3f287a3d6454da89be2fafeaf6e
# Push it to GitHub
git push --set-upstream origin backport/backport-1507-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.16 2.16
# Navigate to the new working tree
cd .worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-1507-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09bf9ce4d661b3f287a3d6454da89be2fafeaf6e
# Push it to GitHub
git push --set-upstream origin backport/backport-1507-to-2.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.16 2.16
# Navigate to the new working tree
cd .worktrees/backport-2.16
# Create a new branch
git switch --create backport/backport-1507-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09bf9ce4d661b3f287a3d6454da89be2fafeaf6e
# Push it to GitHub
git push --set-upstream origin backport/backport-1507-to-2.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1507-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09bf9ce4d661b3f287a3d6454da89be2fafeaf6e
# Push it to GitHub
git push --set-upstream origin backport/backport-1507-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* add ; to tests Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 09bf9ce)
* add ; to tests Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 09bf9ce)
* add ; to tests Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 09bf9ce)
* add ; to tests Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> * fix channel tests in notifications Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 09bf9ce)
Description
This PR fixes the notification channel tests
Issues Resolved
Fixes the CI failure here -> https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/10252949383/job/28365198539
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.