Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cypress Test Flakiness by Executing cy.visit Before cy.request #1537

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix Cypress Test Flakiness by Executing cy.visit Before cy.request #1537

merged 1 commit into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Fix Cypress Test Flakiness by Executing cy.visit Before cy.request 

    This PR addresses intermittent failures in the AD Cypress tests related to a known issue in Cypress (cypress-io/cypress#25397). The specific failure observed was:

```
Sample detector
"before all" hook for "Empty message with modal":
AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="viewSampleDetectorLink"]`, but never found it.
```

To mitigate this issue, we applied a workaround suggested in the GitHub issue, ensuring that cy.visit is executed before cy.request. This change helps stabilize the tests by properly loading AD overview page  before making any API requests.

Testing:
* Ran all Cypress tests with the modified code to verify the fix.

Signed-off-by: Kaituo Li <[email protected]>
    @kaituo
    kaituo committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    13e5e49 View commit details
    Browse the repository at this point in the history