Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Fix workspace functional tests #1556

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Sep 10, 2024

Description

This PR is for fixing failed functional tests cases in workspace plugin mainly includes three changes:

  1. Enable new home page flag in workspace functional tests.
  2. Fix failed workspace functional tests.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam changed the title Fix workspace functional tests [Workspace]Fix workspace functional tests Sep 10, 2024
@wanglam wanglam marked this pull request as draft September 10, 2024 09:16
@wanglam wanglam force-pushed the fix-workspace-functional-tests branch from 21e8470 to ca008d6 Compare September 12, 2024 02:52
@wanglam wanglam changed the base branch from main to 2.x September 12, 2024 02:57
@wanglam wanglam closed this Sep 12, 2024
@wanglam wanglam reopened this Sep 12, 2024
@wanglam wanglam marked this pull request as ready for review September 12, 2024 03:56
@wanglam wanglam force-pushed the fix-workspace-functional-tests branch from c323bed to bb61cf3 Compare November 5, 2024 06:45
@SuZhou-Joe SuZhou-Joe merged commit 8109549 into opensearch-project:2.x Nov 7, 2024
56 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
* Fix functional tests in workspace create and import sample data

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace detail failed

Signed-off-by: Lin Wang <[email protected]>

* Fix lint error

Signed-off-by: Lin Wang <[email protected]>

* Remove no need changes

Signed-off-by: Lin Wang <[email protected]>

* Enable new homepage flag in workspace plugin

Signed-off-by: Lin Wang <[email protected]>

* Remove waitForLoader due to new homepage enabled

Signed-off-by: Lin Wang <[email protected]>

* Update test name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate test cypress result name

Signed-off-by: Lin Wang <[email protected]>

* Fix meta data missing in no auth data source saved object

Signed-off-by: Lin Wang <[email protected]>

* Move selectTopRightNavigationDataSource to utils folder

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace import sample data cases

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace detail cases

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace create failed

Signed-off-by: Lin Wang <[email protected]>

* Add data source associated cases for workspace create

Signed-off-by: Lin Wang <[email protected]>

* Revert "Fix duplicate test cypress result name"

This reverts commit 20d440b.

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact in ml commons

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 8109549)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
* Fix functional tests in workspace create and import sample data

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace detail failed

Signed-off-by: Lin Wang <[email protected]>

* Fix lint error

Signed-off-by: Lin Wang <[email protected]>

* Remove no need changes

Signed-off-by: Lin Wang <[email protected]>

* Enable new homepage flag in workspace plugin

Signed-off-by: Lin Wang <[email protected]>

* Remove waitForLoader due to new homepage enabled

Signed-off-by: Lin Wang <[email protected]>

* Update test name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate test cypress result name

Signed-off-by: Lin Wang <[email protected]>

* Fix meta data missing in no auth data source saved object

Signed-off-by: Lin Wang <[email protected]>

* Move selectTopRightNavigationDataSource to utils folder

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace import sample data cases

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace detail cases

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace create failed

Signed-off-by: Lin Wang <[email protected]>

* Add data source associated cases for workspace create

Signed-off-by: Lin Wang <[email protected]>

* Revert "Fix duplicate test cypress result name"

This reverts commit 20d440b.

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact in ml commons

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 8109549)
wanglam added a commit that referenced this pull request Nov 7, 2024
* Fix functional tests in workspace create and import sample data

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace detail failed

Signed-off-by: Lin Wang <[email protected]>

* Fix lint error

Signed-off-by: Lin Wang <[email protected]>

* Remove no need changes

Signed-off-by: Lin Wang <[email protected]>

* Enable new homepage flag in workspace plugin

Signed-off-by: Lin Wang <[email protected]>

* Remove waitForLoader due to new homepage enabled

Signed-off-by: Lin Wang <[email protected]>

* Update test name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate test cypress result name

Signed-off-by: Lin Wang <[email protected]>

* Fix meta data missing in no auth data source saved object

Signed-off-by: Lin Wang <[email protected]>

* Move selectTopRightNavigationDataSource to utils folder

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace import sample data cases

Signed-off-by: Lin Wang <[email protected]>

* Fix failed workspace detail cases

Signed-off-by: Lin Wang <[email protected]>

* Fix workspace create failed

Signed-off-by: Lin Wang <[email protected]>

* Add data source associated cases for workspace create

Signed-off-by: Lin Wang <[email protected]>

* Revert "Fix duplicate test cypress result name"

This reverts commit 20d440b.

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact name in workspace workflow

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate artifact in ml commons

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 8109549)

Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants