Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting dashboards] Update alerting dashboard tests due to fit and finish changes #1578

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jowg-amazon
Copy link
Contributor

Description

Updated alerting dashboard cypress tests due to fit and finish changes.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jowg-amazon
Copy link
Contributor Author

Alerting tests are all passing locally

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/alerting-dashboards-plugin/      01:26        3        3        -        -        - │
  │    acknowledge_alerts_modal_spec.js                                                            │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      02:29        5        5        -        -        - │
  │    alert_spec.js                                                                               │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:30        2        2        -        -        - │
  │    alerts_dashboard_flyout_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:09        4        4        -        -        - │
  │    bucket_level_monitor_spec.js                                                                │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:07        6        6        -        -        - │
  │    cluster_metrics_monitor_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      00:39        2        2        -        -        - │
  │    composite_level_monitor_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:37        5        5        -        -        - │
  │    document_level_monitor_spec.js                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      00:18        1        1        -        -        - │
  │    monitors_dashboard_spec.js                                                                  │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:25        8        8        -        -        - │
  │    query_level_monitor_spec.js                                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        11:43       36       36        -        -        -  

@jowg-amazon jowg-amazon changed the title Update alerting dashboard tests [Alerting dashboards] Update alerting dashboard tests due to fit and finish changes Oct 3, 2024
@AWSHurneyt
Copy link
Contributor

Could this PR be backported to 2.18 as well please now that the branch has been cut?

@CCongWang CCongWang merged commit 884fdb5 into opensearch-project:main Oct 25, 2024
39 of 40 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 884fdb5)
CCongWang pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 884fdb5)

Co-authored-by: Joanne Wang <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 884fdb5)
CCongWang pushed a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 884fdb5)

Co-authored-by: Joanne Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants