-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting dashboards] Update alerting dashboard tests due to fit and finish changes #1578
Merged
CCongWang
merged 1 commit into
opensearch-project:main
from
jowg-amazon:fix_alerting_tests
Oct 25, 2024
Merged
[Alerting dashboards] Update alerting dashboard tests due to fit and finish changes #1578
CCongWang
merged 1 commit into
opensearch-project:main
from
jowg-amazon:fix_alerting_tests
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowg-amazon
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
September 19, 2024 00:45
Signed-off-by: Joanne Wang <[email protected]>
jowg-amazon
force-pushed
the
fix_alerting_tests
branch
from
October 2, 2024 23:59
6b73c80
to
f902759
Compare
Alerting tests are all passing locally
|
jowg-amazon
changed the title
Update alerting dashboard tests
[Alerting dashboards] Update alerting dashboard tests due to fit and finish changes
Oct 3, 2024
SuZhou-Joe
approved these changes
Oct 3, 2024
Could this PR be backported to 2.18 as well please now that the branch has been cut? |
CCongWang
approved these changes
Oct 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 884fdb5)
CCongWang
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 884fdb5) Co-authored-by: Joanne Wang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 884fdb5)
CCongWang
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 884fdb5) Co-authored-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated alerting dashboard cypress tests due to fit and finish changes.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.