Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] updated traces and services tests with new refresh button #1610

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 29, 2024

Description

[Bug] updated traces and services tests with new refresh button

Issues Resolved

#1549

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <[email protected]>
@ps48
Copy link
Member Author

ps48 commented Oct 29, 2024

Running:  plugins/observability-dashboards/1_trace_analytics_dashboard.spec.js            (2 of 8)
  Testing dashboard table
    ✓ Adds the percentile filters (23574ms)
    ✓ Opens latency trend popover (17254ms)
    ✓ Redirects to traces table with filter (11844ms)
  Testing plots
    ✓ Renders plots (7476ms)
  4 passing (1m)
  (Results)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        4                                                                                │
  │ Passing:      4                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     1 minute, 0 seconds                                                              │
  │ Spec Ran:     plugins/observability-dashboards/1_trace_analytics_dashboard.spec.js             │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
  (Video)
  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /home/runner/work/opensearch-dashboards-functional-test/ope    (6 seconds)
                          nsearch-dashboards-functional-test/cypress-test/cypress/vid               
                          eos/plugins/observability-dashboards/1_trace_analytics_dash               
                          board.spec.js.mp4                                                         
────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/observability-dashboards/2_trace_analytics_services.spec.js             (3 of 8)
  Testing services table
    ✓ Searches correctly (15084ms)
    ✓ Opens service flyout (10641ms)
  2 passing (26s)
  (Results)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      2                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     25 seconds                                                                       │
  │ Spec Ran:     plugins/observability-dashboards/2_trace_analytics_services.spec.js              │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
  (Video)
  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /home/runner/work/opensearch-dashboards-functional-test/ope    (2 seconds)
                          nsearch-dashboards-functional-test/cypress-test/cypress/vid               
                          eos/plugins/observability-dashboards/2_trace_analytics_serv               
                          ices.spec.js.mp4                                                          
────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                    
  Running:  plugins/observability-dashboards/3_trace_analytics_traces.spec.js               (4 of 8)
  Testing traces table
    ✓ Sorts the traces table (12819ms)
    ✓ Searches correctly (8774ms)
  2 passing (22s)
  (Results)
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        2                                                                                │
  │ Passing:      2                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     21 seconds                                                                       │
  │ Spec Ran:     plugins/observability-dashboards/3_trace_analytics_traces.spec.js                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
  (Video)
  -  Started processing:  Compressing to 32 CRF                                                     
  -  Finished processing: /home/runner/work/opensearch-dashboards-functional-test/ope    (2 seconds)
                          nsearch-dashboards-functional-test/cypress-test/cypress/vid               
                          eos/plugins/observability-dashboards/3_trace_analytics_trac               
                          es.spec.js.mp4                                                    
                          ```

@CCongWang CCongWang merged commit afcf1b7 into opensearch-project:2.18 Oct 29, 2024
35 of 37 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 29, 2024
* [Bug]updated traces and services tests with new refresh button

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: sumukhswamy <[email protected]>

* update datetime format check

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: sumukhswamy <[email protected]>
(cherry picked from commit afcf1b7)
CCongWang pushed a commit that referenced this pull request Oct 29, 2024
… (#1611)

* [Bug]updated traces and services tests with new refresh button

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: sumukhswamy <[email protected]>

* update datetime format check

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
Co-authored-by: sumukhswamy <[email protected]>
(cherry picked from commit afcf1b7)

Co-authored-by: Shenoy Pratik <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1610-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 afcf1b7bf40a676e3b3c9b20798f63b4b9b12405
# Push it to GitHub
git push --set-upstream origin backport/backport-1610-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1610-to-main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants