Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate test cypress result name #1624

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Nov 4, 2024

Description

This PR is for fixing upload artifact error due to duplicate artifact names. Here is a failed example:
https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/11659889509/job/32461200995?pr=999
The root cause was a breaking change in upload-artifact v4 from this PR. This action no longer support same upload artifact name.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam marked this pull request as draft November 4, 2024 07:50
@wanglam wanglam marked this pull request as ready for review November 4, 2024 09:32
@ruanyl ruanyl merged commit f87ea71 into opensearch-project:main Nov 5, 2024
58 of 61 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2024
* Fix duplicate test cypress result name

Signed-off-by: Lin Wang <[email protected]>

* Rerun ci groups after base template updated

Signed-off-by: Lin Wang <[email protected]>

* Fix invalid characters in test name

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate due to security

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit f87ea71)
wanglam added a commit that referenced this pull request Nov 5, 2024
* Fix duplicate test cypress result name

Signed-off-by: Lin Wang <[email protected]>

* Rerun ci groups after base template updated

Signed-off-by: Lin Wang <[email protected]>

* Fix invalid characters in test name

Signed-off-by: Lin Wang <[email protected]>

* Fix duplicate due to security

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit f87ea71)

Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants