-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security analytics latest tests #825
Security analytics latest tests #825
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
453f8d0
to
7832d58
Compare
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan should this go into 2.10? |
Yes, it would be nice if it did. I have the tests passing locally but not sure why they are failing to run altogether here |
manual backport: #826 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#834 will suffer from the same issue here
* updated commands to avoid duplication Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated command header for create rule; changed url for searching rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix linter issues Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Updated the tests in this PR |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
…nsearch-project#863) Signed-off-by: Amardeepsingh Siglani <[email protected]>
Updated this PR with all the latest changes that were merged for 2.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only major blocker here is the cypress commands. They are quite generic and can overide similar commands that other tests rely on. Ideally we should split them such that Security analytics specific commands are namespaced and others are moved to the common commands folder, but i'm also okay with just namespacing for now.
cypress/utils/plugins/security-analytics-dashboards-plugin/commands.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Will look into moving common commands to a shared location. For now added |
cypress/utils/plugins/security-analytics-dashboards-plugin/index.js
Outdated
Show resolved
Hide resolved
cypress/utils/plugins/security-analytics-dashboards-plugin/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Amardeepsingh Siglani <[email protected]>
cypress/integration/plugins/security-analytics-dashboards-plugin/1_detectors.spec.js
Outdated
Show resolved
Hide resolved
How is this getting ran? I get failures locally like:
|
The tests passed locally after the changes in latest commit |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-825-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 85c7195aef4ba6ee55a91b025bf614198966886d
# Push it to GitHub
git push --set-upstream origin backport/backport-825-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-825-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 85c7195aef4ba6ee55a91b025bf614198966886d
# Push it to GitHub
git push --set-upstream origin backport/backport-825-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11 Then, create a pull request where the |
* updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * excluded a couple tests; fixed alerts tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * dummy change to trigger tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * Updated cypress commands to avoid duplication (opensearch-project#835) * updated commands to avoid duplication Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated command header for create rule; changed url for searching rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix linter issues Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mappings for test index (opensearch-project#841) Signed-off-by: Amardeepsingh Siglani <[email protected]> * avoid clicking filter menu btn twice (opensearch-project#849) Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed check for url since it differs with and without security (opensearch-project#863) Signed-off-by: Amardeepsingh Siglani <[email protected]> * namespaced all commands; updated tests for 2.11 Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c1f8c39)
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c1f8c39) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Description
Updated tests for security analytics dashboards plugin
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.