[Security Analytics 2.10] Avoid clicking filter menu btn twice #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
amsiglan
changed the title
Hailong-am
approved these changes
Sep 14, 2023
71 tasks
amsiglan
added a commit
to amsiglan/opensearch-dashboards-functional-test
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Oct 11, 2023
* updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * excluded a couple tests; fixed alerts tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * dummy change to trigger tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated command header for create rule; changed url for searching rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix linter issues Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mappings for test index (#841) Signed-off-by: Amardeepsingh Siglani <[email protected]> * avoid clicking filter menu btn twice (#849) Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed check for url since it differs with and without security (#863) Signed-off-by: Amardeepsingh Siglani <[email protected]> * namespaced all commands; updated tests for 2.11 Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
to amsiglan/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 11, 2023
* updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * excluded a couple tests; fixed alerts tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * dummy change to trigger tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * Updated cypress commands to avoid duplication (opensearch-project#835) * updated commands to avoid duplication Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated command header for create rule; changed url for searching rules Signed-off-by: Amardeepsingh Siglani <[email protected]> * fix linter issues Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mappings for test index (opensearch-project#841) Signed-off-by: Amardeepsingh Siglani <[email protected]> * avoid clicking filter menu btn twice (opensearch-project#849) Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed check for url since it differs with and without security (opensearch-project#863) Signed-off-by: Amardeepsingh Siglani <[email protected]> * namespaced all commands; updated tests for 2.11 Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
kavilla
pushed a commit
that referenced
this pull request
Oct 11, 2023
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c1f8c39)
AWSHurneyt
pushed a commit
to AWSHurneyt/opensearch-dashboards-functional-test
that referenced
this pull request
Oct 15, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
ruanyl
pushed a commit
that referenced
this pull request
Oct 16, 2023
…930) * [2.10] Latest tests security analytics (#826) * updated tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * excluded a couple tests; fixed alerts tests Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated mappings for test index (#841) Signed-off-by: Amardeepsingh Siglani <[email protected]> * avoid clicking filter menu btn twice (#849) Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed check for url since it differs with and without security (#863) Signed-off-by: Amardeepsingh Siglani <[email protected]> * excluded flaky test (#891) Signed-off-by: Amardeepsingh Siglani <[email protected]> * Updated security analytics cypress tests for 2.9 patch. Signed-off-by: AWSHurneyt <[email protected]> * Skipping flaky test. Signed-off-by: AWSHurneyt <[email protected]> * Updated alerting cypress tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]>
ruanyl
pushed a commit
that referenced
this pull request
Jan 22, 2024
* updated tests * excluded a couple tests; fixed alerts tests * dummy change to trigger tests * Updated cypress commands to avoid duplication (#835) * updated commands to avoid duplication * updated command header for create rule; changed url for searching rules * fix linter issues --------- * updated mappings for test index (#841) * avoid clicking filter menu btn twice (#849) * removed check for url since it differs with and without security (#863) * namespaced all commands; updated tests for 2.11 * addressed PR comments --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c1f8c39) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking for acknowledged alerts, since the filter menu is already open, clicking the button closes it. This PR fixes the test to avoid opening the menu twice.
Issues Resolved
opensearch-project/security-analytics-dashboards-plugin#690
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.