Cypress tests for data explorer #862

abbyhu2000 · 2023-09-15T17:34:40Z

Description

This PR migrates the old selenium tests for discover to cypress tests for data explorer.
PR for #5003 needs to be merged first.

Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link:

[BUG][Data Explorer] Saved queries does not persist after browser refresh OpenSearch-Dashboards#5071
[BUG][Data Explorer] Large string error on data explorer OpenSearch-Dashboards#5068
[BUG] [Data Explorer] data-shared-item attribute is missing on the discover table OpenSearch-Dashboards#5058
[BUG][Data Explorer] SearchOnPageLoad does not work OpenSearch-Dashboards#5057
[BUG] [Data Explorer] Data Explorer does not respect global time filter anymore OpenSearch-Dashboards#5056

Issues Resolved

resolves opensearch-project/OpenSearch-Dashboards#4781

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cypress.json

kavilla · 2023-09-19T23:44:52Z

cypress/fixtures/dashboard/opensearch_dashboards/data_explorer/date_nanos_mix/data.json.txt

@@ -0,0 +1,95 @@
+{
+  "type": "doc",


can some of this be zipped up?

...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js

kavilla · 2023-09-19T23:47:07Z

AWESOME! Will verify later this week. Made some quick comments we should also verify with security enabled. Targetting 2.11?

abbyhu2000 · 2023-09-19T23:48:26Z

AWESOME! Will verify later this week. Made some quick comments we should also verify with security enabled. Targetting 2.11?

yea i think it is targeting 2.11 @ashwin-pc

ashwin-pc

Firstly, really good job with the PR. The tests look good and well written. Im partway though the review by have a general question about cleanup. You are adding a lot of fixtures and changing settings. @kavilla Do you think we need to remove the fixtures after each test/test suite?

cypress/utils/dashboards/data_explorer/constants.js

cypress/utils/dashboards/data_explorer/commands.js

package.json

...egration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/sidebar.spec.js

...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js

kavilla · 2023-09-25T23:20:33Z

You are adding a lot of fixtures and changing settings. @kavilla Do you think we need to remove the fixtures after each test/test suite?

@ashwin-pc that's a good point, the selenium tests would check if load an add them if needed where as some plugins really rely on a fresh state.

Perhaps instead of creating a helper function to check and optimize it can be apart of the cypress env variables where it defaults deletes these values after each spec. and we can configure it from our CI to not delete per spec.

Another work around (which isn't a catchall) but we ensure the complete uniqueness of the data index created.

ashwin-pc · 2023-09-25T23:21:20Z

P.S. Dont merge this until feature/deangular is merged into main for OSD.

ashwin-pc

@abbyhu2000 can you add the recordings for these tests to the PR?

...ion/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js

ashwin-pc · 2023-09-26T18:45:43Z

@kavilla hmm, that seems like that can come as a followup. Want to put some more thought into that. I'm okay with this going in as is for now and following up with improvements to test improvements later when we have a better solution for cleanup.

kavilla · 2023-09-28T01:55:48Z

@abbyhu2000 @ashwin-pc I think maybe we should consider optimizing the uploading data. Or we start building in the ciGroup stuff since I see this PR increasing the time of the test run:

opensearch-project/OpenSearch-Dashboards#5134 (comment).

I thought it was failing but I believe it was working just fine just taking a while. (Sorry about the format, i have another PR to fix the formatting issue)

abbyhu2000 · 2023-10-04T05:34:25Z

Wrote a function importJSONDocIfNeeded to optimize uploading data, it will save time if the indices are already loaded in a previous test.

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>

abbyhu2000 · 2023-10-13T18:15:14Z

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/6504499657 <-- cypress tests pass with ciGroups

Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 7cf0a03)

Migrate the old selenium tests for discover to cypress tests for data explorer. PR [for #5003](opensearch-project/OpenSearch-Dashboards#5072) needs to be merged first. Below are a list of bugs found when writing the tests, the tests for the below feature are skipped and commented with the issue link: - opensearch-project/OpenSearch-Dashboards#5071 - opensearch-project/OpenSearch-Dashboards#5068 - opensearch-project/OpenSearch-Dashboards#5058 - opensearch-project/OpenSearch-Dashboards#5057 - opensearch-project/OpenSearch-Dashboards#5056 ### Issues Resolved resolves opensearch-project/OpenSearch-Dashboards#4781 --------- Signed-off-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 7cf0a03) Co-authored-by: Qingyang(Abby) Hu <[email protected]>

abbyhu2000 requested review from xluo-aws, Hailong-am, SuZhou-Joe, ruanyl, wanglam and raintygao as code owners September 15, 2023 17:34

abbyhu2000 marked this pull request as draft September 15, 2023 17:34

abbyhu2000 force-pushed the discover_app branch from 92e6842 to 09ffa75 Compare September 18, 2023 18:52

abbyhu2000 marked this pull request as ready for review September 19, 2023 22:24

abbyhu2000 mentioned this pull request Sep 19, 2023

Add data-test-subj for data explorer cypress test opensearch-project/OpenSearch-Dashboards#5072

Merged

8 tasks

kavilla reviewed Sep 19, 2023

View reviewed changes

cypress.json Outdated Show resolved Hide resolved

kavilla reviewed Sep 19, 2023

View reviewed changes

...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js Show resolved Hide resolved

ashwin-pc added backport 2.x v2.11.0 labels Sep 20, 2023

ashwin-pc reviewed Sep 20, 2023

View reviewed changes

abbyhu2000 commented Sep 21, 2023

View reviewed changes

...ation/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js Show resolved Hide resolved

abbyhu2000 mentioned this pull request Sep 21, 2023

[Data Explorer] Delete legacy discover selenium tests opensearch-project/OpenSearch-Dashboards#5088

Merged

ashwin-pc reviewed Sep 25, 2023

View reviewed changes

kavilla reviewed Sep 25, 2023

View reviewed changes

...ion/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js Show resolved Hide resolved

abbyhu2000 force-pushed the discover_app branch 3 times, most recently from d63f76d to 17b8d61 Compare October 4, 2023 21:04

abbyhu2000 added 10 commits October 10, 2023 14:39

unchange the package.json

4f6de1c

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

fix error test

cc237fc

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

update test library tar file

7509245

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

fix linter error in package.lock

ef912d6

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

fix error on github ci

f4d5f90

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

add some skip tests due to flakiness

62b34c0

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

fix ci opensearch-project#1

6dda269

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

fix shared_link

192828d

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

clear index pattern

c31bebd

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

remove unnecessary import

ae461ca

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

abbyhu2000 force-pushed the discover_app branch from 9414658 to ae461ca Compare October 10, 2023 21:39

add before after

4e4a809

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

abbyhu2000 force-pushed the discover_app branch from 5128d68 to 4e4a809 Compare October 11, 2023 01:42

seperate tests into cigroups

a22eaa6

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

abbyhu2000 force-pushed the discover_app branch from 6eda0e0 to a22eaa6 Compare October 11, 2023 05:49

abbyhu2000 mentioned this pull request Oct 11, 2023

Add cigroup for cypress workflow #917

Closed

1 task

abbyhu2000 and others added 2 commits October 11, 2023 17:25

fix

0b94b1f

Signed-off-by: Qingyang(Abby) Hu <[email protected]>

Remove single quote

9accebb

Signed-off-by: Kawika Avilla <[email protected]>

kavilla approved these changes Oct 13, 2023

View reviewed changes

kavilla added the backport 2.11 label Oct 13, 2023

ananzh approved these changes Oct 13, 2023

View reviewed changes

kavilla merged commit 7cf0a03 into opensearch-project:main Oct 13, 2023
33 of 38 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 13, 2023

[Backport 2.x] Cypress tests for data explorer #928

Merged

opensearch-trigger-bot bot mentioned this pull request Oct 13, 2023

[Backport 2.11] Cypress tests for data explorer #929

Merged

abbyhu2000 mentioned this pull request Oct 25, 2023

[Test] [Data Explorer] Add new cypress test for testing discover related advanced settings opensearch-project/OpenSearch-Dashboards#5269

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress tests for data explorer #862

Cypress tests for data explorer #862

abbyhu2000 commented Sep 15, 2023 •

edited

Loading

kavilla Sep 19, 2023

kavilla commented Sep 19, 2023 •

edited

Loading

abbyhu2000 commented Sep 19, 2023

ashwin-pc left a comment

kavilla commented Sep 25, 2023

ashwin-pc commented Sep 25, 2023

ashwin-pc left a comment

ashwin-pc commented Sep 26, 2023

kavilla commented Sep 28, 2023 •

edited

Loading

abbyhu2000 commented Oct 4, 2023

abbyhu2000 commented Oct 13, 2023

Cypress tests for data explorer #862

Cypress tests for data explorer #862

Conversation

abbyhu2000 commented Sep 15, 2023 • edited Loading

Description

Issues Resolved

Check List

kavilla Sep 19, 2023

Choose a reason for hiding this comment

kavilla commented Sep 19, 2023 • edited Loading

abbyhu2000 commented Sep 19, 2023

ashwin-pc left a comment

Choose a reason for hiding this comment

kavilla commented Sep 25, 2023

ashwin-pc commented Sep 25, 2023

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc commented Sep 26, 2023

kavilla commented Sep 28, 2023 • edited Loading

abbyhu2000 commented Oct 4, 2023

abbyhu2000 commented Oct 13, 2023

abbyhu2000 commented Sep 15, 2023 •

edited

Loading

kavilla commented Sep 19, 2023 •

edited

Loading

kavilla commented Sep 28, 2023 •

edited

Loading