-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis builder] get correct element #869
Merged
kavilla
merged 1 commit into
opensearch-project:2.10
from
kavilla:kavilla/fixvisbuildertest
Sep 18, 2023
Merged
[Vis builder] get correct element #869
kavilla
merged 1 commit into
opensearch-project:2.10
from
kavilla:kavilla/fixvisbuildertest
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finds the correct element when loading instead of a regular visualization loader. Error easier to catch since wait for loader is less flakey. Issue: opensearch-project/OpenSearch-Dashboards#5043 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
September 16, 2023 02:05
Hailong-am
approved these changes
Sep 18, 2023
ruanyl
approved these changes
Sep 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
Finds the correct element when loading instead of a regular visualization loader. Error easier to catch since wait for loader is less flakey. Issue: opensearch-project/OpenSearch-Dashboards#5043 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 56a74e8)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-869-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56a74e8d88df9054e83676c171e5a627235f1b9e
# Push it to GitHub
git push --set-upstream origin backport/backport-869-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10 Then, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
Finds the correct element when loading instead of a regular visualization loader. Error easier to catch since wait for loader is less flakey. Issue: opensearch-project/OpenSearch-Dashboards#5043 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 56a74e8)
kavilla
added a commit
that referenced
this pull request
Sep 25, 2023
Finds the correct element when loading instead of a regular visualization loader. Error easier to catch since wait for loader is less flakey. Issue: opensearch-project/OpenSearch-Dashboards#5043 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 56a74e8) Co-authored-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Oct 6, 2023
Finds the correct element when loading instead of a regular visualization loader. Error easier to catch since wait for loader is less flakey. Issue: opensearch-project/OpenSearch-Dashboards#5043 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 56a74e8) Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finds the correct element when loading instead of a regular visualization loader.
Error easier to catch since wait for loader is less flakey.
Issues Resolved
opensearch-project/OpenSearch-Dashboards#5043
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.