Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis builder] get correct element #869

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 16, 2023

Description

Finds the correct element when loading instead of a regular visualization loader.

Error easier to catch since wait for loader is less flakey.

Issues Resolved

opensearch-project/OpenSearch-Dashboards#5043

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Finds the correct element when loading instead of a regular
visualization loader.

Error easier to catch since wait for loader is less flakey.

Issue:
opensearch-project/OpenSearch-Dashboards#5043

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla merged commit 56a74e8 into opensearch-project:2.10 Sep 18, 2023
32 of 36 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2023
Finds the correct element when loading instead of a regular
visualization loader.

Error easier to catch since wait for loader is less flakey.

Issue:
opensearch-project/OpenSearch-Dashboards#5043

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 56a74e8)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-869-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 56a74e8d88df9054e83676c171e5a627235f1b9e
# Push it to GitHub
git push --set-upstream origin backport/backport-869-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-869-to-2.10.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2023
Finds the correct element when loading instead of a regular
visualization loader.

Error easier to catch since wait for loader is less flakey.

Issue:
opensearch-project/OpenSearch-Dashboards#5043

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 56a74e8)
kavilla added a commit that referenced this pull request Sep 25, 2023
Finds the correct element when loading instead of a regular
visualization loader.

Error easier to catch since wait for loader is less flakey.

Issue:
opensearch-project/OpenSearch-Dashboards#5043

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 56a74e8)

Co-authored-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Oct 6, 2023
Finds the correct element when loading instead of a regular
visualization loader.

Error easier to catch since wait for loader is less flakey.

Issue:
opensearch-project/OpenSearch-Dashboards#5043

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 56a74e8)

Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants