[Index-mgmt 2.x] Renamed index to avoid collision for other tests #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
should it be in main? |
Hailong-am
approved these changes
Sep 19, 2023
ruanyl
reviewed
Sep 19, 2023
cypress/integration/plugins/index-management-dashboards-plugin/indices_spec.js
Outdated
Show resolved
Hide resolved
Yes, created PR #879 |
btw, you could leverage the backport workflow to port the changes to |
ruanyl
approved these changes
Sep 20, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
kavilla
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During one of the tests for indices, we create an index with name
reindex_opensearch_dashboards_sample_data_ecommercethat is superstring for the sample indexopensearch_dashboards_sample_data_ecommerce. This new index is supposed to get deleted but sometimes it might not get deleted due to failure in backend and after that if some other test looks for the sample index and tries to select that index from a combo box, it faces collision and might end up not selecting any index. This PR renames the new index to avoid this situation.Manual backport for 2.10 in #873
Issues Resolved
Fixes flaky test in Index Management Dashboards - opensearch-project/index-management-dashboards-plugin#880
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.