Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated alerting and security analytics cypress tests for 2.9 patch. #930

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

AWSHurneyt
Copy link
Contributor

Description

Updated security analytics cypress tests for 2.9 patch.

Submitting this PR directly to the 2.9 branch for expediency. I'll create a separate PR to the main branch with the necessary backport labels.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

amsiglan and others added 6 commits October 13, 2023 18:29
* updated tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* excluded a couple tests; fixed alerts tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@AWSHurneyt
Copy link
Contributor Author

AWSHurneyt commented Oct 16, 2023

All security analytics tests pass locally.

====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/security-analytics-dashboar      10:34       13       10        -        3        - │
  │    ds-plugin/1_detectors.spec.js                                                               │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/security-analytics-dashboar      14:10       16       16        -        -        - │
  │    ds-plugin/2_rules.spec.js                                                                   │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/security-analytics-dashboar      04:40        8        7        -        1        - │
  │    ds-plugin/3_alerts.spec.js                                                                  │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/security-analytics-dashboar      04:25        5        5        -        -        - │
  │    ds-plugin/4_findings.spec.js                                                                │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        33:50       42       38        -        4        -  

✨  Done in 2452.65s.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review October 16, 2023 05:09
@AWSHurneyt AWSHurneyt changed the title Updated security analytics cypress tests for 2.9 patch. Updated alerting and security analytics cypress tests for 2.9 patch. Oct 16, 2023
@ruanyl
Copy link
Member

ruanyl commented Oct 16, 2023

Could you please post screenshot of the results for alerting-dashboards-plugin of your local? The GitHub workflow is failed.

@amsiglan
Copy link
Contributor

Passing alerting tests:

  1. AcknowledgeAlertsModal
image 2. Alerts image 3. AlertsDashboardFlyout image
  1. BucketLevelMonitor
image
  1. CluserMetricsMonitor
image
  1. DocumentLevelMonitor
image
  1. QueryLevelMonitor
image

@ruanyl ruanyl merged commit af53f24 into opensearch-project:2.9 Oct 16, 2023
31 of 32 checks passed
@AWSHurneyt
Copy link
Contributor Author

Could you please post screenshot of the results for alerting-dashboards-plugin of your local? The GitHub workflow is failed.

Here are screenshots of the alerting dashboards tests passing.
Screenshot 2023-10-16 at 8 15 21 AM
Screenshot 2023-10-16 at 8 19 30 AM
Screenshot 2023-10-16 at 8 22 51 AM
Screenshot 2023-10-16 at 8 31 09 AM
Screenshot 2023-10-16 at 8 38 03 AM
Screenshot 2023-10-16 at 8 43 09 AM
Screenshot 2023-10-16 at 8 47 18 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants