Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken ci flow in Node 18 #947

Closed
wants to merge 20 commits into from
Closed

fix: broken ci flow in Node 18 #947

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ebd4522
fix: broken ci flow in Node 18
SuZhou-Joe Nov 1, 2023
299d19a
fix: broken ci flow in Node 18
SuZhou-Joe Nov 1, 2023
007a14f
feat: run with headless=new
SuZhou-Joe Nov 1, 2023
2ca3977
fix: headless args
SuZhou-Joe Nov 1, 2023
b324ebe
fix: headless args
SuZhou-Joe Nov 1, 2023
a340a0a
feat: add logs
SuZhou-Joe Nov 2, 2023
2093eff
feat: add debug info
SuZhou-Joe Nov 2, 2023
b62fcb0
feat: add debug info
SuZhou-Joe Nov 2, 2023
90e1b52
feat: add debug info
SuZhou-Joe Nov 2, 2023
32a9300
fix: disable some logs to stop browser from crashing
SuZhou-Joe Nov 2, 2023
5d60804
feat: revert useless code
SuZhou-Joe Nov 2, 2023
b99e256
feat: add comment
SuZhou-Joe Nov 15, 2023
5892879
feat: change the way to make ipv4 first
SuZhou-Joe Nov 15, 2023
0e53fa2
temp: run all the e2e test
SuZhou-Joe Nov 15, 2023
db0f7a8
feat: upgrade cypress to 12.15.0
SuZhou-Joe Nov 15, 2023
6e29313
feat: update package.lock
SuZhou-Joe Nov 15, 2023
235f063
feat: remove cypress.json
SuZhou-Joe Nov 15, 2023
2b71ef5
feat: use cypress.config.js
SuZhou-Joe Nov 15, 2023
71fe3cc
feat: use cypress.config.js
SuZhou-Joe Nov 15, 2023
d5ae7c6
feat: add specPattern
SuZhou-Joe Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cypress-workflow-vanilla-snapshot-based.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}-linux-x64
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-e2e-workflow-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ jobs:
./bin/opensearch-dashboards-plugin remove securityDashboards
sed -i /^opensearch_security/d config/opensearch_dashboards.yml
sed -i 's/https/http/' config/opensearch_dashboards.yml
bin/opensearch-dashboards serve ${{ inputs.osd-serve-args }} &
bin/opensearch-dashboards serve --server.host="0.0.0.0" ${{ inputs.osd-serve-args }} &
timeout 300 bash -c 'while [[ "$(curl http://localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
curl http://localhost:5601/api/status
else
echo "Keep Dashboards Security"
bin/opensearch-dashboards serve ${{ inputs.osd-serve-args }} &
bin/opensearch-dashboards serve --server.host="0.0.0.0" ${{ inputs.osd-serve-args }} &
timeout 300 bash -c 'while [[ "$(curl -u admin:admin -k http://localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
curl http://localhost:5601/api/status -u admin:admin --insecure
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chrome.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium-ad-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium-ism-only.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium-tests-in-memory-0.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium-tests-in-memory-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium-tests-in-memory-20.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-chromium.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-electron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-signoff-firefox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Run OpenSearch-Dashboards server
run: |
cd opensearch-dashboards-${{ env.VERSION }}
bin/opensearch-dashboards serve &
bin/opensearch-dashboards serve --server.host="0.0.0.0" &
timeout 300 bash -c 'while [[ "$(curl -s localhost:5601/api/status | jq -r '.status.overall.state')" != "green" ]]; do sleep 5; done'
- name: Get Cypress version
id: cypress_version
Expand Down
3 changes: 2 additions & 1 deletion cypress.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"VISBUILDER_ENABLED": true,
"DATASOURCE_MANAGEMENT_ENABLED": false,
"ML_COMMONS_DASHBOARDS_ENABLED": true,
"WAIT_FOR_LOADER_BUFFER_MS": 0
"WAIT_FOR_LOADER_BUFFER_MS": 0,
"NO_COMMAND_LOG": 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: could you elaborate this change? seems not related to this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Chrome 117 the test will hang because of browser crash. According to the doc here it seems the only option we can choose.

It is better to leave a comment here but it seems we can not write comment in json file.

}
}
16 changes: 16 additions & 0 deletions cypress/plugins/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,20 @@
module.exports = (on, config) => {
// `on` is used to hook into various events Cypress emits
// `config` is the resolved Cypress config
on('before:browser:launch', (browser = {}, launchOptions) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here, could you elaborate a bit? seems not related to this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added comment above the code.

if (
(browser.name === 'chrome' || browser.name === 'chromium') &&
browser.isHeadless
) {
launchOptions.args = launchOptions.args.map((arg) => {
if (arg === '--headless') {
return '--headless=new';
}

return arg;
});
}

return launchOptions;
});
};
Loading