feat: remove useless vanilla test #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
xluo-aws,
Hailong-am,
ruanyl,
wanglam and
raintygao
as code owners
|
will look at this. thanks! |
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
fix/flaky-vanilla-test
branch
from
1a464d6
to
d1533f8
Compare
|
Hi @kavilla @tianleh @seraphjiang , we are running a campaign to reduce flaky test in FTRepo. Do you think it's safe that we skip the vanilla test? |
kavilla
approved these changes
Dec 20, 2023
Signed-off-by: SuZhou-Joe <[email protected]>
|
nonblocking: please remove the reference here as well $ yarn cypress:run-without-security --spec "cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/*.js" |
tianleh
approved these changes
Dec 26, 2023
Signed-off-by: SuZhou-Joe <[email protected]>
wanglam
approved these changes
Dec 27, 2023
raintygao
approved these changes
Dec 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
* feat: skip flaky test Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless test case Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless reference Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 1fa3e2b)
SuZhou-Joe
added a commit
that referenced
this pull request
Dec 27, 2023
* feat: skip flaky test Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless test case Signed-off-by: SuZhou-Joe <[email protected]> * feat: remove useless reference Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 1fa3e2b) Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cypress/integration/core-opensearch-dashboards/vanilla-opensearch-dashboards/dashboard_filtering_spec.jstest is not needed and it is never run on OSS release process. As it is flaky and keeps failing normal PR workflow actions, we decide to remove this spec.More context: #961 (comment)
Issues Resolved
#961
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.