Add tests for the new homepage #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
ashwin-pc
approved these changes
Jan 12, 2024
AMoo-Miki
force-pushed
the
fix-home
branch
2 times, most recently
from
6741569
to
2a21d22
Compare
wanglam
approved these changes
Jan 16, 2024
kavilla
reviewed
Jan 16, 2024
| describe('checking legacy home page', () => { | ||
| before(() => { | ||
| // Go to the home page | ||
| miscUtils.visitPage('app/home#'); |
There was a problem hiding this comment.
have we checked with the security plugin installed?
There was a problem hiding this comment.
While I fixed a typo here, this piece is an existing code. If it was being checked before, it will be checked now too.
|
do we have an associated PR for these changes? |
|
Signed-off-by: Miki <[email protected]>
ruanyl
approved these changes
Jan 22, 2024
ashwin-pc
merged commit ad62d3e
into
opensearch-project:feature/new-home
28 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.