Change stack dependency and update readme #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon and
prudhvigodithi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage ? 89.47%
=======================================
Files ? 2
Lines ? 38
Branches ? 4
=======================================
Hits ? 34
Misses ? 4
Partials ? 0 ☔ View full report in Codecov by Sentry. |
nightly-playground/README.md
Outdated
|
|
||
| #### Sample command to set up multi-node cluster with security enabled | ||
| #### Sample command to set up nighly playground cluster |
| @@ -77,5 +75,6 @@ export class NightlyPlaygroundStack { | |||
| this.stacks.push(infraStack); | |||
|
|
|||
| infraStack.addDependency(networkStack); | |||
| infraStack.addDependency(commonToolsStack); | |||
There was a problem hiding this comment.
This means commonsStack needs to be ready before infra stack is deployed
Signed-off-by: Sayali Gaikawad <[email protected]>
|
Closing this PR as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The commonToolsStack is only required by infra stack. Hence changing the dependency from network stack to infra stack.
Also update the readme with new Params
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.