Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Codegen equals & hashCode #1217

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[Backport 2.x] Codegen equals & hashCode #1217

merged 2 commits into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. Generate hashCode and equals (opensearch-project#1201) 

    * Generate hashCode and equals , wip

Signed-off-by: miguel-vila <[email protected]>

* add changelog entry

Signed-off-by: miguel-vila <[email protected]>

* remove change

Signed-off-by: miguel-vila <[email protected]>

* take into account primitives

Signed-off-by: miguel-vila <[email protected]>

* refactor and format

Signed-off-by: miguel-vila <[email protected]>

* use Object.equals

Co-authored-by: Thomas Farr <[email protected]>
Signed-off-by: Miguel Vilá <[email protected]>

* use `&&` chain

Signed-off-by: miguel-vila <[email protected]>

* adjust last line

Signed-off-by: miguel-vila <[email protected]>

* use fqn

Signed-off-by: miguel-vila <[email protected]>

* use fqn for Objects.hashCode, take into account parent

Signed-off-by: miguel-vila <[email protected]>

* remove unused var definition

Signed-off-by: miguel-vila <[email protected]>

* codegen equals/hashCode for request shapes

Signed-off-by: miguel-vila <[email protected]>

* add hashCode/equals to TaggedUnion

Signed-off-by: miguel-vila <[email protected]>

* use import

Signed-off-by: miguel-vila <[email protected]>

* fix equals for request shapes

Signed-off-by: miguel-vila <[email protected]>

* codegen latest from main

Signed-off-by: miguel-vila <[email protected]>

---------

Signed-off-by: miguel-vila <[email protected]>
Signed-off-by: Miguel Vilá <[email protected]>
Co-authored-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 18a8460)
    @Xtansia
    Xtansia committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a981eb7 View commit details
    Browse the repository at this point in the history

  2. Re-run codegen (opensearch-project#1216) 

    * Re-run codegen

Signed-off-by: Thomas Farr <[email protected]>

* Improve null handling

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 897cc9b)
    @Xtansia
    Xtansia committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a640485 View commit details
    Browse the repository at this point in the history