Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Override to generated equals & hashCode #1249

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 23, 2024

Description

Add @Override to generated equals & hashCode

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia merged commit 282f415 into opensearch-project:main Oct 23, 2024
66 checks passed
@Xtansia Xtansia deleted the feat/code-gen/equals-hashcode-override branch October 23, 2024 20:39
Xtansia added a commit to Xtansia/opensearch-java that referenced this pull request Nov 3, 2024
Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 282f415)
Xtansia added a commit that referenced this pull request Nov 4, 2024
* Improve code generation (#1219)

- Render descriptions using markdown
- Support generating "DictionaryResponse" types
- Support discriminated unions

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit d045d86)

* Use latest spec

Signed-off-by: Thomas Farr <[email protected]>

* Add `@Override` to equals & hashCode (#1249)

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 282f415)

* Begin generating index CRUD operations (#1220)

* Generate indices.get

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.exists

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.create

Signed-off-by: Thomas Farr <[email protected]>

* Generate indices.delete

Signed-off-by: Thomas Farr <[email protected]>

* Cleanup SourceFieldMode

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit b962e89)

* Generate KnnVectorProperty

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 6a930ad)

* Add PR number

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants