-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added size attribute to MultiTermsAggregation #614
Conversation
Code for size Attribute is analog to TermsAggregation Signed-off-by: Fabian Kopatschek <[email protected]>
Signed-off-by: Fabian Kopatschek <[email protected]>
...rc/main/java/org/opensearch/client/opensearch/_types/aggregations/MultiTermsAggregation.java
Outdated
Show resolved
Hide resolved
Thanks for contribution @fabiankopatschek , could you please add a test cases under |
Signed-off-by: Fabian Kopatschek <[email protected]>
Also this should go against |
I really would like to add a test case. But unfortunately i'm not able to run the integration tests. The AggregationRequestIT for example failes with this message:
Any tips on how to fix this? |
Are you running with Eclipse? Or gradle? |
I'm running the tests in the shell with gradle. |
You are very right, the issue seems to be caused by latest software.amazon.awssdk 2.20.141 (which is imported using version range). Created an issue for it here #615 |
Description
Added size attribute to MultiTermsAggregation to retreive other hit sizes than the default value of the attribute.
Code for the added attribute was taken from TermsAggregation class.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.