-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving "software.amazon.awssdk" dependencies to the compileOnly scope. #628
Conversation
Thanks! could you please check DCO ( |
Signed-off-by: Dmitry Kaukov <[email protected]>
Signed-off-by: Dmitry Kaukov <[email protected]>
@dkaukov could you please add a changelog entry, thank you |
Signed-off-by: Dmitry Kaukov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dkaukov!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 66608d3450865f6ee0d6b4e924ed7aaac74ba88d
# Push it to GitHub
git push --set-upstream origin backport/backport-628-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
opensearch-project#628) * move "software.amazon.awssdk" dependencies to the compileOnly scope. Signed-off-by: Dmitry Kaukov <[email protected]> * PR feedback Signed-off-by: Dmitry Kaukov <[email protected]> * PR feedback Signed-off-by: Dmitry Kaukov <[email protected]> --------- Signed-off-by: Dmitry Kaukov <[email protected]> Signed-off-by: Vacha Shah <[email protected]>
Backport in #634 |
#628) (#634) * move "software.amazon.awssdk" dependencies to the compileOnly scope. * PR feedback * PR feedback --------- Signed-off-by: Dmitry Kaukov <[email protected]> Signed-off-by: Vacha Shah <[email protected]> Co-authored-by: Dmitry Kaukov <[email protected]>
Description
Current build configuration leaking "software.amazon.awssdk" dependencies to the final POM:
Which breaks some maven plugins (notable https://github.com/basepom/dependency-versions-check-maven-plugin) which tries to download all possible versions of the SDK in range.
Issues Resolved
By changing scope to the
compileOnly
, we completely removing this dependencies from final POMBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.