Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Restore support for Java 8 #798

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jan 3, 2024

Backport f8ec75e from #795 and #777, closes #778, #156

@dblock
Copy link
Member

dblock commented Jan 3, 2024

@reta Backport most of this and comment out CI or let's open an issue to re-add JDK8 to 2.x and link this and other PRs?

@reta
Copy link
Collaborator

reta commented Jan 3, 2024

@reta Backport most of this and comment out CI or let's open an issue to re-add JDK8 to 2.x and link this and other PRs?

@dblock reopened this one #778

@reta reta force-pushed the backport/backport-795-to-2.x branch 2 times, most recently from bdbd3e4 to 5dbf167 Compare January 3, 2024 22:24
@reta reta changed the title [Backport 2.x] Add an integration test that runs on JDK-8 [Backport 2.x] Restore support for Java 8 Jan 3, 2024
Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking till 2.12.0. release is out (@dblock @VachaShah fyi)

@cb-pankajk
Copy link

Hi @dblock / @VachaShah,
when will this be released? I am currently using 1.0.0 (java 8 compatible) with a bug fixed in 2.1.0 (java 8 incompatible). If possible, can we backport the fix on 1.x?

@reta
Copy link
Collaborator

reta commented Feb 12, 2024

when will this be released? I am currently using 1.0.0 (java 8 compatible) with a bug fixed in 2.1.0 (java 8 incompatible). If possible, can we backport the fix on 1.x?

Hi @cb-pankajk it will be released right after OpenSearch 2.12.0 release (the planned release date as of today is Feb 20), thank you

@dblock
Copy link
Member

dblock commented Feb 12, 2024

If possible, can we backport the fix on 1.x?

@cb-pankajk I don't think we want to maintain/re-release a 1.x unless it's a security vulnerability, but maybe @reta or @VachaShah feel otherwise? Either way you'll have to do the backport work.

@reta reta force-pushed the backport/backport-795-to-2.x branch from 5dbf167 to eec10a5 Compare February 21, 2024 13:50
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-795-to-2.x branch from eec10a5 to efc7dd7 Compare February 21, 2024 13:55
@reta reta self-requested a review February 21, 2024 14:03
@reta
Copy link
Collaborator

reta commented Feb 21, 2024

@dblock @VachaShah we should be all set for 2.x now :)

@VachaShah
Copy link
Collaborator

@dblock @VachaShah we should be all set for 2.x now :)

Awesome!

@VachaShah VachaShah merged commit 7acd729 into 2.x Feb 21, 2024
81 checks passed
@github-actions github-actions bot deleted the backport/backport-795-to-2.x branch February 21, 2024 18:52
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants