Implement middleware types to allow intercepting client & request han…

…dling (#232)

* Implement middleware types to allow intercepting client & request handling

Signed-off-by: Thomas Farr <[email protected]>

* Add changelog entry

Signed-off-by: Thomas Farr <[email protected]>

* Relax position of clone bounds

Signed-off-by: Thomas Farr <[email protected]>

* Move is_send_sync check behind test cfg

Signed-off-by: Thomas Farr <[email protected]>

* Rename RequestPipeline to RequestHandlerChain

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>

CHANGELOG.md

@@ -6,6 +6,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Internalized the `BuildError` type, consolidating on the `Error` type ([#228](https://github.com/opensearch-project/opensearch-rs/pull/228))
 
 ### Added
+- Added middleware types to allow intercepting construction and handling of the underlying `reqwest` client & requests ([#232](https://github.com/opensearch-project/opensearch-rs/pull/232)) 
 
 ### Dependencies
 - Bumps `aws-*` dependencies to `1` ([#219](https://github.com/opensearch-project/opensearch-rs/pull/219))

opensearch/Cargo.toml

@@ -29,6 +29,7 @@ rustls-tls = ["reqwest/rustls-tls"]
 aws-auth = ["aws-credential-types", "aws-sigv4", "aws-smithy-runtime-api", "aws-types"]
 
 [dependencies]
+async-trait = "0.1"
 base64 = "0.21"
 bytes = "1.0"
 dyn-clone = "1"

opensearch/src/client.rs

@@ -104,3 +104,13 @@ impl OpenSearch {
             .await
     }
 }
+
+#[cfg(test)]
+mod test {
+    #[test]
+    fn client_is_send_sync() {
+        // Ensure that the client is `Send` and `Sync`
+        fn is_send_sync<T: Send + Sync>() {}
+        is_send_sync::<super::OpenSearch>()
+    }
+}

opensearch/src/error.rs

@@ -35,7 +35,10 @@
 
 use crate::{
     cert::CertificateError,
-    http::{transport, StatusCode},
+    http::{
+        middleware::{RequestHandlerError, RequestHandlerErrorKind},
+        transport, StatusCode,
+    },
 };
 
 pub(crate) type BoxError<'a> = Box<dyn std::error::Error + Send + Sync + 'a>;
@@ -53,7 +56,7 @@ where
     Kind: From<E>,
 {
     fn from(error: E) -> Self {
-        Self(Kind::from(error))
+        Self(error.into())
     }
 }
 
@@ -80,11 +83,32 @@ enum Kind {
     #[cfg(feature = "aws-auth")]
     #[error("AwsSigV4 error: {0}")]
     AwsSigV4(#[from] crate::http::aws_auth::AwsSigV4Error),
+
+    #[error("request initializer error: {0}")]
+    RequestInitializer(#[source] BoxError<'static>),
+
+    #[error("request handler error: {0}")]
+    RequestHandler(#[source] BoxError<'static>),
+}
+
+impl From<RequestHandlerError> for Kind {
+    fn from(err: RequestHandlerError) -> Self {
+        use RequestHandlerErrorKind::*;
+
+        match err.0 {
+            Handler(err) => Self::RequestHandler(err),
+            Http(err) => Self::Http(err),
+        }
+    }
 }
 
 use Kind::*;
 
 impl Error {
+    pub(crate) fn request_initializer(err: BoxError<'static>) -> Self {
+        Self(RequestInitializer(err))
+    }
+
     /// The status code, if the error was generated from a response
     pub fn status_code(&self) -> Option<StatusCode> {
         match &self.0 {

opensearch/src/http/middleware/initializers/client.rs

@@ -0,0 +1,47 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */
+
+use super::InitializerResult;
+use crate::BoxError;
+use reqwest::ClientBuilder;
+
+pub trait ClientInitializer: 'static {
+    type Result: InitializerResult<ClientBuilder>;
+
+    fn init(self, client: ClientBuilder) -> Self::Result;
+}
+
+impl<F, R> ClientInitializer for F
+where
+    F: FnOnce(ClientBuilder) -> R + 'static,
+    R: InitializerResult<ClientBuilder>,
+{
+    type Result = R;
+
+    fn init(self, client: ClientBuilder) -> Self::Result {
+        self(client)
+    }
+}
+
+pub(crate) trait BoxedClientInitializer {
+    fn init(self: Box<Self>, client: ClientBuilder) -> Result<ClientBuilder, BoxError<'static>>;
+}
+
+impl<T> BoxedClientInitializer for T
+where
+    T: ClientInitializer + Sized,
+{
+    fn init(self: Box<Self>, client: ClientBuilder) -> Result<ClientBuilder, BoxError<'static>> {
+        ClientInitializer::init(*self, client)
+            .into_result()
+            .map_err(Into::into)
+    }
+}

opensearch/src/http/middleware/initializers/mod.rs

@@ -0,0 +1,44 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */
+
+mod client;
+mod request;
+
+use crate::BoxError;
+use std::convert::Infallible;
+
+pub use client::*;
+pub use request::*;
+
+pub trait InitializerResult<T> {
+    type Error: Into<BoxError<'static>>;
+
+    fn into_result(self) -> Result<T, Self::Error>;
+}
+
+impl<T, E> InitializerResult<T> for Result<T, E>
+where
+    E: Into<BoxError<'static>>,
+{
+    type Error = E;
+
+    fn into_result(self) -> Result<T, Self::Error> {
+        self
+    }
+}
+
+impl<T> InitializerResult<T> for T {
+    type Error = Infallible;
+
+    fn into_result(self) -> Result<T, Infallible> {
+        Ok(self)
+    }
+}

opensearch/src/http/middleware/initializers/request.rs

@@ -0,0 +1,86 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */
+
+use super::InitializerResult;
+use crate::BoxError;
+use reqwest::RequestBuilder;
+
+pub trait RequestInitializer: std::fmt::Debug + Send + Sync + 'static {
+    type Result: InitializerResult<RequestBuilder>;
+
+    fn init(&self, request: RequestBuilder) -> Self::Result;
+}
+
+#[derive(Clone)]
+pub struct RequestInitializerFn<F>(F);
+
+pub fn request_initializer_fn<F>(f: F) -> RequestInitializerFn<F> {
+    RequestInitializerFn(f)
+}
+
+impl<F> std::fmt::Debug for RequestInitializerFn<F> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct(stringify!(RequestInitializerFn)).finish()
+    }
+}
+
+impl<F, R> RequestInitializer for RequestInitializerFn<F>
+where
+    F: Fn(RequestBuilder) -> R + Send + Sync + 'static,
+    R: InitializerResult<RequestBuilder>,
+{
+    type Result = R;
+
+    fn init(&self, request: RequestBuilder) -> Self::Result {
+        self.0(request)
+    }
+}
+
+impl<R> RequestInitializer for std::sync::Arc<R>
+where
+    R: RequestInitializer,
+{
+    type Result = R::Result;
+
+    fn init(&self, request: RequestBuilder) -> Self::Result {
+        self.as_ref().init(request)
+    }
+}
+
+impl<R> RequestInitializer for std::sync::Arc<dyn RequestInitializer<Result = R>>
+where
+    R: InitializerResult<RequestBuilder> + 'static,
+{
+    type Result = R;
+
+    fn init(&self, request: RequestBuilder) -> Self::Result {
+        self.as_ref().init(request)
+    }
+}
+
+pub(crate) trait BoxedRequestInitializer:
+    dyn_clone::DynClone + std::fmt::Debug + Send + Sync + 'static
+{
+    fn init(&self, request: RequestBuilder) -> Result<RequestBuilder, BoxError<'static>>;
+}
+
+impl<T> BoxedRequestInitializer for T
+where
+    T: RequestInitializer + Clone,
+{
+    fn init(&self, request: RequestBuilder) -> Result<RequestBuilder, BoxError<'static>> {
+        RequestInitializer::init(self, request)
+            .into_result()
+            .map_err(Into::into)
+    }
+}
+
+dyn_clone::clone_trait_object!(BoxedRequestInitializer);

opensearch/src/http/middleware/mod.rs

@@ -0,0 +1,20 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */
+
+mod initializers;
+mod request_handler;
+
+pub use async_trait::async_trait;
+pub use initializers::*;
+pub use request_handler::*;
+
+pub(crate) type BoxFuture<'a, T> =
+    std::pin::Pin<Box<dyn std::future::Future<Output = T> + Send + 'a>>;