Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly bound aws-* dependency versions #215

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Nov 20, 2023

Description

There were (erroneously?) published 1.0 versions of some of the dependencies, which caused them to be picked up while they're incompatible with other aws- deps

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <[email protected]>
@Xtansia Xtansia added backport 2.x Backport to the 2.x branch backport 2.2 Backport to the 2.2 branch labels Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (374fcac) 73.82% compared to head (b1e21e3) 73.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   73.82%   73.54%   -0.28%     
==========================================
  Files         403      398       -5     
  Lines       64243    62557    -1686     
==========================================
- Hits        47425    46009    -1416     
+ Misses      16818    16548     -270     
Flag Coverage Δ
integration 73.54% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xtansia Xtansia merged commit a80f8d6 into opensearch-project:main Nov 20, 2023
37 of 38 checks passed
@Xtansia Xtansia deleted the fix/aws-version-req branch November 20, 2023 21:04
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Correctly bound `aws-*` dependency versions

Signed-off-by: Thomas Farr <[email protected]>

* Changelog entry

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit a80f8d6)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Correctly bound `aws-*` dependency versions

Signed-off-by: Thomas Farr <[email protected]>

* Changelog entry

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit a80f8d6)
Xtansia added a commit that referenced this pull request Nov 20, 2023
* Correctly bound `aws-*` dependency versions

Signed-off-by: Thomas Farr <[email protected]>

* Changelog entry

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit a80f8d6)

Co-authored-by: Thomas Farr <[email protected]>
Xtansia added a commit that referenced this pull request Nov 20, 2023
* Correctly bound `aws-*` dependency versions

Signed-off-by: Thomas Farr <[email protected]>

* Changelog entry

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit a80f8d6)

Co-authored-by: Thomas Farr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to the 2.x branch backport 2.2 Backport to the 2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants