-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dev guide with the correct GET route. #944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
joshpalis,
owaiskazi19,
ryanbogan,
saratvemulapalli and
dbwiddis
as code owners
September 26, 2023 21:25
@dblock we have spotless for MD files as well 😛. |
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
dev-guide-hello
branch
from
September 26, 2023 22:04
5ccb2bc
to
34bdd1f
Compare
owaiskazi19
approved these changes
Sep 27, 2023
dbwiddis
approved these changes
Oct 2, 2023
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-sdk-java/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-sdk-java/backport-1.x
# Create a new branch
git switch --create backport/backport-944-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee55c5d36854e7b4d8c43afc4dc6b0c0212ccf92
# Push it to GitHub
git push --set-upstream origin backport/backport-944-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-sdk-java/backport-1.x Then, create a pull request where the |
dbwiddis
pushed a commit
to dbwiddis/opensearch-sdk-java
that referenced
this pull request
Oct 2, 2023
Signed-off-by: dblock <[email protected]>
dbwiddis
pushed a commit
to dbwiddis/opensearch-sdk-java
that referenced
this pull request
Oct 9, 2023
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
dblock
added a commit
that referenced
this pull request
Oct 13, 2023
* Updated dev guide with the correct GET route. (#944) Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> * chore(deps): update plugin com.diffplug.spotless to v6.22.0 (#946) (#947) (cherry picked from commit 16d82f2) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed up dev guide, notably using the correct GET route for the hello world request.
Added a JSON configuration file to avoid POSTing the entire JSON body when registering the extension.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.