Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dev guide with the correct GET route. #944

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 26, 2023

Description

Fixed up dev guide, notably using the correct GET route for the hello world request.
Added a JSON configuration file to avoid POSTing the entire JSON body when registering the extension.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19
Copy link
Member

@dblock we have spotless for MD files as well 😛.
./gradlew :spotlessApply to fix the spotless failures.

@dbwiddis dbwiddis merged commit ee55c5d into opensearch-project:main Oct 2, 2023
7 checks passed
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-sdk-java/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-sdk-java/backport-1.x
# Create a new branch
git switch --create backport/backport-944-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee55c5d36854e7b4d8c43afc4dc6b0c0212ccf92
# Push it to GitHub
git push --set-upstream origin backport/backport-944-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-sdk-java/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-944-to-1.x.

dbwiddis pushed a commit to dbwiddis/opensearch-sdk-java that referenced this pull request Oct 2, 2023
@dblock dblock deleted the dev-guide-hello branch October 2, 2023 16:18
dbwiddis pushed a commit to dbwiddis/opensearch-sdk-java that referenced this pull request Oct 9, 2023
dblock added a commit that referenced this pull request Oct 13, 2023
* Updated dev guide with the correct GET route. (#944)

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>

* chore(deps): update plugin com.diffplug.spotless to v6.22.0 (#946) (#947)

(cherry picked from commit 16d82f2)

Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>

---------

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants