Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v9 theme colors and revert button background colors #1430

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Oct 3, 2024

Description

This reverts the button background colors change in 1.14 (removing new variable but given issues + short time frame thing its okay) and updates colors for v9 theme.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@virajsanghvi virajsanghvi changed the title Update v9 theme colors and revert background button colors Update v9 theme colors and revert button background colors Oct 3, 2024
@virajsanghvi
Copy link
Collaborator Author

note: failing test in osd due to other changes

@virajsanghvi virajsanghvi marked this pull request as ready for review October 3, 2024 20:19
@AMoo-Miki AMoo-Miki merged commit ed8dbe5 into opensearch-project:main Oct 3, 2024
20 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
Signed-off-by: Viraj Sanghvi <[email protected]>
(cherry picked from commit ed8dbe5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
virajsanghvi pushed a commit that referenced this pull request Oct 3, 2024
…1431)

Signed-off-by: Viraj Sanghvi <[email protected]>
(cherry picked from commit ed8dbe5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants