feat: add sparkle_filled icon #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
4 tasks
|
Can you add a changelog entry? May need to update changelog per last release. |
AMoo-Miki
approved these changes
Oct 30, 2024
Signed-off-by: Yulong Ruan <[email protected]>
ashwin-pc
approved these changes
Oct 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
* feat: add sparkle_filled icon Signed-off-by: Yulong Ruan <[email protected]> * doc(changelog): add changelog for newly add sparkle icon Signed-off-by: Yulong Ruan <[email protected]> --------- Signed-off-by: Yulong Ruan <[email protected]> (cherry picked from commit 7233b5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Nov 13, 2024
* feat: add sparkle_filled icon * doc(changelog): add changelog for newly add sparkle icon --------- (cherry picked from commit 7233b5a) Signed-off-by: Yulong Ruan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.