-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build steps to workflow #665
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5eccb80
Add build steps to workflow
BSFishy 5ca3e86
Add path filter
BSFishy 2968677
Remove path filter
BSFishy 0f5f22b
Merge branch 'main' into add_build_step
joshuarrrr a4d846f
Merge branch 'main' into add_build_step
BSFishy ea96e95
Update yarn version for build CI
BSFishy fe3ec69
Remove Windows from build CI
BSFishy b4ed738
Revert yarn version and add changlog entry
BSFishy bbc42f2
Remove workflow matrix
BSFishy d757fff
Add artifact upload steps
BSFishy 10a8093
Set workflow to upload artifacts as package
BSFishy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,9 @@ on: | |
- '**/*.md' | ||
|
||
jobs: | ||
build-lint-test: | ||
lint-test: | ||
runs-on: ${{ matrix.os }} | ||
name: Build and Verify | ||
name: Lint and Test on ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest] | ||
|
@@ -39,3 +39,49 @@ jobs: | |
|
||
- name: Run unit tests | ||
run: yarn test-unit | ||
|
||
build: | ||
runs-on: ${{ matrix.os }} | ||
name: Build on ${{ matrix.os }} | ||
needs: lint-test | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-latest] | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version-file: '.nvmrc' | ||
registry-url: 'https://registry.npmjs.org' | ||
cache: 'yarn' | ||
|
||
- name: Setup Yarn | ||
run: | | ||
npm uninstall -g yarn | ||
npm i -g [email protected] | ||
yarn install --frozen-lockfile | ||
|
||
- name: Path filter | ||
uses: dorny/paths-filter@v2 | ||
id: filter | ||
with: | ||
filters: | | ||
src: | ||
- 'src/**' | ||
- package.json | ||
- yarn.lock | ||
docs: | ||
- 'src-docs/**' | ||
- package.json | ||
- yarn.lock | ||
|
||
- name: Build | ||
if: steps.filter.outputs.src == 'true' | ||
run: yarn build | ||
|
||
- name: Build Docs | ||
if: steps.filter.outputs.docs == 'true' | ||
run: yarn build-docs |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reviewers: should other related build files be added here? Ex.
postcss.config.js
,tsconfig.json
, ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think adding those is a good idea. It's hard to know whether an allowlist or a denylist is easier in this case.