Bump eslint to version v8
#952
Conversation
gulderov
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
| const { field: sortable, direction: sortDirection } = ( | ||
| sorting as SortingOptions | ||
| ).sort; |
There was a problem hiding this comment.
Feel like I personally prefer the old version of this, but we can follow up on code style in another task
There was a problem hiding this comment.
I feel the same way. I'm not a big fan of Prettier, but it's used in the project regardless.
| @@ -12,19 +12,19 @@ | |||
| // This file uses RGBA literal values responsibly | |||
| // This file uses off-pattern indentation to be more readable | |||
|
|
|||
| // sass-lint:disable no-color-literals, no-color-keywords, indentation, quotes | |||
| // sass-lint:disable no-color-literals, no-color-keywords, indentation, quotes, hex-length hex-notation leading-zero | |||
There was a problem hiding this comment.
I'm wondering if there was really a need to disable "hex-length", "hex-notation", "leading-zero"? I've also noticed this in other files as well
There was a problem hiding this comment.
They would trigger sass-lint errors if not muted
| /* eslint-disable import/named */ | ||
| import { | ||
| FixedSizeList, | ||
| ListProps, | ||
| ListChildComponentProps as ReactWindowListChildComponentProps, | ||
| areEqual, | ||
| } from 'react-window'; | ||
| /* eslint-enable import/named */ |
There was a problem hiding this comment.
Can we avoid these disabling comments, maybe we can add some rules to eslint config?
There was a problem hiding this comment.
The issue should be resolved by the typings for react-window, which is out of the scope of this pull request. Personally, I prefer to avoid making changes to the eslint config and to keep it as limited as possible
gulderov
force-pushed
the
eslint-bump
branch
from
9329b65
to
03450ba
Compare
|
It seems like there are build errors caused by maybe a prettier api change? Seems to be an issue on these lines: oui/scripts/derive-sass-variable-types.js Lines 55 to 56 in a5576f3 |
gulderov
force-pushed
the
eslint-bump
branch
from
dd509bf
to
6ef0c94
Compare
Description
Please review
eslintupdate to version 8.46.0The primary intent of this PR is to update tooling. No functionality or logic has been altered
Changes:
eslintfrom 7.10.0 to 8.46.0prettierfrom 2.1.2 to 3.0.1eslint --fixandsass-lintto auto fix new warningsjsxBracketSameLinein favor ofbracketSameLineoptionparserconfiguration asprettieris able to autodetectjsxSingleQuote,semiandprintWithIssues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.