Fix blurry breadcrumb text #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
BSFishy
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Matt Provost <[email protected]>
BSFishy
commented
Aug 10, 2023
| font-weight: $ouiFontWeightMedium; | ||
| } | ||
|
|
||
| .ouiBreadcrumb--collapsed { | ||
| flex-shrink: 0; | ||
| color: $ouiBreadcrumbCollapsedLink; |
There was a problem hiding this comment.
More link finagling (#624)
|
This looks much better, and thanks for taking a pass at using 'primary' color for the breadcrumb treatment! I am wondering if #938 will help improve the presentation even further? One note I have is that the keyboard highlight is very tight around the text in the collapsed state - however I don't consider this a blocker to the PR for these reasons:
|
KrooshalUX
approved these changes
Aug 10, 2023
I don't think so. The only place where $ouiBreadcrumbTextColor: makeHighContrastColor($ouiTextSubduedColor, $ouiBreadcrumbGrayBackground) !default; |
AMoo-Miki
approved these changes
Aug 10, 2023
joshuarrrr
reviewed
Aug 11, 2023
There was a problem hiding this comment.
Awesome @BSFishy , looks like a great fix! I just have some minor suggestions about variable names.
CHANGELOG.md
Outdated
| @@ -15,6 +15,8 @@ | |||
|
|
|||
| ### 🐛 Bug Fixes | |||
|
|
|||
| - Fix blurry text in breadcrumbs ([#959](https://github.com/opensearch-project/oui/pull/959)) | |||
There was a problem hiding this comment.
Suggested change
| - Fix blurry text in breadcrumbs ([#959](https://github.com/opensearch-project/oui/pull/959)) | |
| - Fix blurry text in breadcrumbs by avoiding skewing text ([#959](https://github.com/opensearch-project/oui/pull/959)) |
Signed-off-by: Matt Provost <[email protected]>
joshuarrrr
approved these changes
Aug 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Fix blurry breadcrumb text Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> * Address reviews Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit fe979c3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
joshuarrrr
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Fix blurry breadcrumb text Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> * Address reviews Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> (cherry picked from commit fe979c3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix blurry text in breadcrumbs by using
:beforepseudoelement. Also took this opportunity to make breadcrumb colors come from theme. All accessibility checks pass.Current light
Current dark
Next light
Next dark
Issues Resolved
Mostly/completely fixes #902
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.