Update ouiTextSubduedColor in next dark theme
#973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shade the theme's `$ouiTextColor` instead of using one of the grayscale shades Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Josh Romero <[email protected]>
|
@KrooshalUX Let me know if you want to move forward with this approach, tweak the calculation, or just provide an explicit value. |
AMoo-Miki
approved these changes
Aug 22, 2023
|
@joshuarrrr do you have other non collapsable nav examples? Its a bit hard to tell if its the right way to go as I believe subdued is used in a lot of form controls and button states. |
Signed-off-by: Josh Romero <[email protected]>
AMoo-Miki
approved these changes
Aug 22, 2023
KrooshalUX
approved these changes
Aug 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Update ouiTextSubduedColor in `next` dark theme Shade the theme's `$ouiTextColor` instead of using one of the grayscale shades Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit 309e146) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BSFishy
pushed a commit
that referenced
this pull request
Sep 8, 2023
* Update ouiTextSubduedColor in `next` dark theme Shade the theme's `$ouiTextColor` instead of using one of the grayscale shades Signed-off-by: Josh Romero <[email protected]> * update changelog Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> (cherry picked from commit 309e146) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shade the theme's
$ouiTextColorinstead of using one of the grayscale shades. Only affectsnextdark theme.Issues Resolved
fixes #938
fixes #955
demo shows the various pseudo states
Screen.Recording.2023-08-16.at.4.55.09.PM.mov
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.