Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-sass to a version based on [email protected] #977

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Aug 17, 2023

Description

Bumps node-sass to a version that uses [email protected] as the original deprecated one is based on vulnerable [email protected].

Most of this work was done in #912

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
@joshuarrrr
Copy link
Member

@BSFishy Can you provide a brief description of what your patch for sass-loader does? And either create a new issue or add to #966

@BSFishy
Copy link
Contributor Author

BSFishy commented Aug 17, 2023

@BSFishy Can you provide a brief description of what your patch for sass-loader does? And either create a new issue or add to #966

Added new comment: #966 (comment)

@AMoo-Miki AMoo-Miki merged commit 24fb2b1 into opensearch-project:main Aug 22, 2023
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2023
* Update to libsass 3.6.5

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

* Revert extraneous yarn lock changes

Signed-off-by: Matt Provost <[email protected]>

* Remove incorrect comments

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 24fb2b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki pushed a commit that referenced this pull request Aug 22, 2023
* Update to libsass 3.6.5

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

* Revert extraneous yarn lock changes

Signed-off-by: Matt Provost <[email protected]>

* Remove incorrect comments

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>
(cherry picked from commit 24fb2b1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BSFishy BSFishy deleted the sass/node-sass-9 branch August 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants