Remove PA-RCA files from OS home dir

[kjoseph07]

Signed-off-by: Karishma Joseph [email protected]

[Merge only when PA is stable]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer#82

Describe the solution you are proposing
Remove the<OS_HOME>/performance-analyzer-rca folder from the OS home directory. This way there is only one location for PA plugin and PA-RCA process: <OS_HOME>/plugins/opensearch-performance-analyzer.

Contents of <OS_HOME>/performance-analyzer-rca before:

bin  lib  pa_bin  pa_config

pa_bin and pa_config in <OS_HOME>/performance-analyzer-rca and <OS_HOME>/plugins/opensearch-performance-analyzer were exactly the same. Hence, no action needs to be taken for these two folders.

Copy bin into <OS_HOME>/plugins/opensearch-performance-analyzer and rename as rca_bin.

Copy lib into <OS_HOME>/plugins/opensearch-performance-analyzer and rename as rca_lib. Remove all the common library files between <OS_HOME>/plugins/opensearch-performance-analyzer and <OS_HOME>/plugins/opensearch-performance-analyzer/rca_lib so as to reduce the memory footprint.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #133 (91dfa6d) into main (702fc58) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 91dfa6d differs from pull request most recent head bdb2eea. Consider uploading reports for the commit bdb2eea to get more accurate results

@@             Coverage Diff              @@
##               main     #133      +/-   ##
============================================
+ Coverage     71.90%   71.94%   +0.04%     
- Complexity     2943     2946       +3     
============================================
  Files           376      376              
  Lines         18766    18765       -1     
  Branches       1436     1436              
============================================
+ Hits          13494    13501       +7     
+ Misses         4686     4679       -7     
+ Partials        586      585       -1     

Impacted Files	Coverage Δ
.../org/opensearch/performanceanalyzer/core/Util.java	60.86% <ø> (-1.64%)	⬇️
...formanceanalyzer/rca/framework/util/RcaConsts.java	89.47% <100.00%> (ø)
...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java	87.12% <0.00%> (+0.99%)	⬆️
...nsearch/performanceanalyzer/rca/RcaController.java	80.61% <0.00%> (+1.32%)	⬆️
...formanceanalyzer/PerformanceAnalyzerWebServer.java	74.62% <0.00%> (+5.97%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702fc58...bdb2eea. Read the comment docs.

[dblock]

LGTM, needs CI to pass

[sruti1312]

Build is failing as IT's are not passing. Dockerfile also needs to be updated and tested.

Error during reproducing this error.

opensearch1    | Error: could not find config file /usr/share/opensearch/performance-analyzer-rca/pa_config/supervisord.conf
opensearch1    | For help, use /usr/bin/supervisord -h
opensearch2    | Unlinking stale socket /usr/share/supervisor/performance_analyzer/supervisord.sock
opensearch1 exited with code 2

[dblock]

Looks stalled, closing. Please feel free to finish this @kjoseph07.

[Catch All Triage - Attendees 1, 2, 3, 4, 5]