Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Searchbackpressure Service Reader and UTs added #495

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 53e3b94 from #427

* Remove log files and add DCO (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove extra files (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove styling difference (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove unnecessary file changes (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Use Commons package for metric table naming and column naming (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove unnecessary comments and add more descriptive comments (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove unnecessary global variables (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Add comments and adjust UTs (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove tab space and change avg datatype to LONG  (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Remove tab space and change avg datatype to LONG and additional JAVADOC (Signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

* Add description for searchbp stats in sqlitedb (signed-off-by: Jeffrey Liu [email protected])

Signed-off-by: CoderJeffrey <[email protected]>

---------

Signed-off-by: CoderJeffrey <[email protected]>
(cherry picked from commit 53e3b94)
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #495 (e596ea1) into 2.x (d29ac81) will increase coverage by 0.27%.
The diff coverage is 91.40%.

❗ Current head e596ea1 differs from pull request most recent head 7b0b0d3. Consider uploading reports for the commit 7b0b0d3 to get more accurate results

@@             Coverage Diff              @@
##                2.x     #495      +/-   ##
============================================
+ Coverage     75.64%   75.91%   +0.27%     
- Complexity     2580     2605      +25     
============================================
  Files           303      305       +2     
  Lines         15415    15636     +221     
  Branches       1218     1224       +6     
============================================
+ Hits          11660    11870     +210     
- Misses         3264     3272       +8     
- Partials        491      494       +3     
Files Coverage Δ
...eanalyzer/rca/framework/metrics/ReaderMetrics.java 97.56% <100.00%> (+0.06%) ⬆️
...ormanceanalyzer/reader/ReaderMetricsProcessor.java 79.33% <100.00%> (+0.61%) ⬆️
...yzer/reader/SearchBackPressureMetricsSnapShot.java 98.63% <98.63%> (ø)
...zer/reader/SearchBackPressureMetricsProcessor.java 89.18% <89.18%> (ø)
...rch/performanceanalyzer/reader/MetricsEmitter.java 94.82% <83.33%> (-0.82%) ⬇️

... and 4 files with indirect coverage changes

@khushbr khushbr merged commit aef3981 into 2.x Oct 5, 2023
5 of 8 checks passed
@khushbr khushbr added the v2.11.0 Issues targeting release v2.11.0 label Oct 5, 2023
@github-actions github-actions bot deleted the backport/backport-427-to-2.x branch October 5, 2023 18:39
khushbr added a commit to khushbr/performance-analyzer-rca that referenced this pull request Oct 6, 2023
khushbr added a commit that referenced this pull request Oct 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
khushbr added a commit that referenced this pull request Oct 6, 2023
#504) (#505)

This reverts commit aef3981.

(cherry picked from commit c9fd492)

Co-authored-by: Khushboo Rajput <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants