Remove PA-RCA files from OS home dir #143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karishma Joseph [email protected]
[Merge only when PA is stable]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#82
Describe the solution you are proposing
Remove the
<OS_HOME>/performance-analyzer-rca
folder from the OS home directory. This way there is only one location for PA plugin and PA-RCA process:<OS_HOME>/plugins/opensearch-performance-analyzer
.Contents of
<OS_HOME>/performance-analyzer-rca
before:pa_bin
andpa_config
in<OS_HOME>/performance-analyzer-rca
and<OS_HOME>/plugins/opensearch-performance-analyzer
were exactly the same. Hence, no action needs to be taken for these two folders.Copy
bin
into<OS_HOME>/plugins/opensearch-performance-analyzer
and rename asrca_bin
.Copy
lib
into<OS_HOME>/plugins/opensearch-performance-analyzer
and rename asrca_lib
. Remove all the common library files between<OS_HOME>/plugins/opensearch-performance-analyzer
and<OS_HOME>/plugins/opensearch-performance-analyzer/rca_lib
so as to reduce the memory footprint.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.