Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PA-RCA files from OS home dir #143

Closed
wants to merge 1 commit into from

Conversation

kjoseph07
Copy link
Contributor

@kjoseph07 kjoseph07 commented Feb 25, 2022

Signed-off-by: Karishma Joseph [email protected]

[Merge only when PA is stable]

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#82

Describe the solution you are proposing
Remove the<OS_HOME>/performance-analyzer-rca folder from the OS home directory. This way there is only one location for PA plugin and PA-RCA process: <OS_HOME>/plugins/opensearch-performance-analyzer.

Contents of <OS_HOME>/performance-analyzer-rca before:

bin  lib  pa_bin  pa_config

pa_bin and pa_config in <OS_HOME>/performance-analyzer-rca and <OS_HOME>/plugins/opensearch-performance-analyzer were exactly the same. Hence, no action needs to be taken for these two folders.

Copy bin into <OS_HOME>/plugins/opensearch-performance-analyzer and rename as rca_bin.

Copy lib into <OS_HOME>/plugins/opensearch-performance-analyzer and rename as rca_lib. Remove all the common library files between <OS_HOME>/plugins/opensearch-performance-analyzer and <OS_HOME>/plugins/opensearch-performance-analyzer/rca_lib so as to reduce the memory footprint.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kjoseph07 kjoseph07 requested a review from a team February 25, 2022 23:21
@codecov-commenter
Copy link

Codecov Report

Merging #143 (f46c994) into main (b086d2f) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head f46c994 differs from pull request most recent head abc861d. Consider uploading reports for the commit abc861d to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #143      +/-   ##
============================================
- Coverage     72.19%   72.03%   -0.16%     
+ Complexity      356      355       -1     
============================================
  Files            44       44              
  Lines          2510     2510              
  Branches        160      160              
============================================
- Hits           1812     1808       -4     
- Misses          592      595       +3     
- Partials        106      107       +1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 55.95% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b086d2f...abc861d. Read the comment docs.

@dblock
Copy link
Member

dblock commented Mar 22, 2022

Can we merge this?

@sruti1312 sruti1312 requested a review from sgup432 April 6, 2022 00:39
@kkhatua kkhatua marked this pull request as draft January 27, 2023 01:47
@dblock
Copy link
Member

dblock commented Jul 1, 2024

Looks stalled, closing. Please feel free to finish and reopen @kjoseph07.

@dblock dblock closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants