Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreceate NodeStatsFixedShardsMetricsCollector in favor of NodeStatsAllShardsMetricsCollector #551

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Sep 30, 2023

NodeStatsAllShardsMetricsCollector is already released, redundant to run NodeStatsFixedShardsMetricsCollector. The Collector can further be removed in the future revision.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…AllShardsMetricsCollector

Signed-off-by: Khushboo Rajput <[email protected]>
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #551 (06dffd0) into main (27a6b56) will decrease coverage by 4.88%.
The diff coverage is n/a.

❗ Current head 06dffd0 differs from pull request most recent head c5ecb14. Consider uploading reports for the commit c5ecb14 to get more accurate results

@@             Coverage Diff              @@
##               main     #551      +/-   ##
============================================
- Coverage     73.90%   69.02%   -4.88%     
+ Complexity      381      370      -11     
============================================
  Files            45       45              
  Lines          2698     2696       -2     
  Branches        172      172              
============================================
- Hits           1994     1861     -133     
- Misses          596      731     +135     
+ Partials        108      104       -4     
Files Coverage Δ
...performanceanalyzer/PerformanceAnalyzerPlugin.java 76.92% <ø> (-0.22%) ⬇️
...collectors/NodeStatsAllShardsMetricsCollector.java 91.15% <ø> (ø)
...llectors/NodeStatsFixedShardsMetricsCollector.java 0.00% <ø> (-92.71%) ⬇️
...org/opensearch/performanceanalyzer/util/Utils.java 92.30% <ø> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

@@ -251,7 +251,7 @@ jacocoTestCoverageVerification {
violationRules {
rule {
limit {
minimum = 0.6
minimum = 0.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to reduce coverage percentage

Copy link
Collaborator Author

@khushbr khushbr Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but in this case, the build on the repo depends on coverage verification and will fail now that we are ignoring the redundant NodeStatsFixedShardsMetricsCollectorTests.java.

The coverage increase will have to be separately addressed from this PR.

@@ -34,7 +34,10 @@
import org.opensearch.performanceanalyzer.util.Utils;

/**
* This collector collects metrics for fixed number of shards on a node in a single run. These
* Note: 'NodeStatsAllShardsMetricsCollector' is already released and out of shadow mode, this class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we cannot remove this as part of current release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the standard practice of marking the class deprecated in (n-1) release and finally removing in nth release.

@khushbr khushbr merged commit e7713ba into opensearch-project:main Oct 2, 2023
7 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
…AllShardsMetricsCollector (#551)

Signed-off-by: Khushboo Rajput <[email protected]>
(cherry picked from commit e7713ba)
khushbr added a commit that referenced this pull request Oct 5, 2023
…AllShardsMetricsCollector (#551) (#559)

Signed-off-by: Khushboo Rajput <[email protected]>
(cherry picked from commit e7713ba)

Co-authored-by: Khushboo Rajput <[email protected]>
@khushbr khushbr added the v2.11.0 Issues targeting release v2.11.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 2.x v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants