-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depreceate NodeStatsFixedShardsMetricsCollector in favor of NodeStatsAllShardsMetricsCollector #551
Conversation
…AllShardsMetricsCollector Signed-off-by: Khushboo Rajput <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
============================================
- Coverage 73.90% 69.02% -4.88%
+ Complexity 381 370 -11
============================================
Files 45 45
Lines 2698 2696 -2
Branches 172 172
============================================
- Hits 1994 1861 -133
- Misses 596 731 +135
+ Partials 108 104 -4
|
@@ -251,7 +251,7 @@ jacocoTestCoverageVerification { | |||
violationRules { | |||
rule { | |||
limit { | |||
minimum = 0.6 | |||
minimum = 0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better not to reduce coverage percentage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but in this case, the build on the repo depends on coverage verification and will fail now that we are ignoring the redundant NodeStatsFixedShardsMetricsCollectorTests.java
.
The coverage increase will have to be separately addressed from this PR.
@@ -34,7 +34,10 @@ | |||
import org.opensearch.performanceanalyzer.util.Utils; | |||
|
|||
/** | |||
* This collector collects metrics for fixed number of shards on a node in a single run. These | |||
* Note: 'NodeStatsAllShardsMetricsCollector' is already released and out of shadow mode, this class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we cannot remove this as part of current release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the standard practice of marking the class deprecated in (n-1) release and finally removing in nth release.
…AllShardsMetricsCollector (#551) Signed-off-by: Khushboo Rajput <[email protected]> (cherry picked from commit e7713ba)
…AllShardsMetricsCollector (#551) (#559) Signed-off-by: Khushboo Rajput <[email protected]> (cherry picked from commit e7713ba) Co-authored-by: Khushboo Rajput <[email protected]>
NodeStatsAllShardsMetricsCollector
is already released, redundant to runNodeStatsFixedShardsMetricsCollector
. The Collector can further be removed in the future revision.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.