Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove redundant ClusterManagerThrottlingMetricsCollector #583

Merged
merged 1 commit into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ jacocoTestReport {
],
exclude: [
'**/FaultDetectionMetricsCollector.class',
'**/ClusterManagerThrottlingMetricsCollector.class',
'**/ClusterSettingsManager.class',
])
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import org.opensearch.performanceanalyzer.collectors.ClusterApplierServiceStatsCollector;
import org.opensearch.performanceanalyzer.collectors.ClusterManagerServiceEventMetrics;
import org.opensearch.performanceanalyzer.collectors.ClusterManagerServiceMetrics;
import org.opensearch.performanceanalyzer.collectors.ClusterManagerThrottlingMetricsCollector;
import org.opensearch.performanceanalyzer.collectors.ElectionTermCollector;
import org.opensearch.performanceanalyzer.collectors.FaultDetectionMetricsCollector;
import org.opensearch.performanceanalyzer.collectors.NodeDetailsCollector;
Expand Down Expand Up @@ -216,9 +215,6 @@ public PerformanceAnalyzerPlugin(final Settings settings, final java.nio.file.Pa
performanceAnalyzerController, configOverridesWrapper));
scheduledMetricCollectorsExecutor.addScheduledMetricCollector(
new ShardStateCollector(performanceAnalyzerController, configOverridesWrapper));
scheduledMetricCollectorsExecutor.addScheduledMetricCollector(
new ClusterManagerThrottlingMetricsCollector(
performanceAnalyzerController, configOverridesWrapper));
scheduledMetricCollectorsExecutor.addScheduledMetricCollector(
new ClusterApplierServiceStatsCollector(
performanceAnalyzerController, configOverridesWrapper));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public void collectMetrics(long startTime) {
| IllegalAccessException
| ClassNotFoundException e) {
LOG.debug(
"[ {} ] Exception raised while getting Cluster Manager throttling metrics: {} ",
"[ {} ] Exception raised while getting Cluster Manager Service Event metrics: {} ",
this::getCollectorName,
e::getMessage);
StatsCollector.instance().logException(CLUSTER_MANAGER_METRICS_ERROR);
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ public static void configureMetrics() {
MetricsConfiguration.CONFIG_MAP.put(ClusterManagerServiceMetrics.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(FaultDetectionMetricsCollector.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(ShardStateCollector.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(
ClusterManagerThrottlingMetricsCollector.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(ClusterApplierServiceStatsCollector.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(ElectionTermCollector.class, cdefault);
MetricsConfiguration.CONFIG_MAP.put(ShardIndexingPressureMetricsCollector.class, cdefault);
Expand Down

This file was deleted.

Loading